Skip to content

Conversation

@kanikaram-sejal
Copy link
Collaborator

No description provided.

@kanikaram-sejal kanikaram-sejal linked an issue Mar 15, 2025 that may be closed by this pull request
@naomitzhao naomitzhao self-requested a review March 17, 2025 23:07
Copy link
Collaborator

@naomitzhao naomitzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this technically works for the mixins we have defined, note that the layout has unexpected behavior in between the breakpoints. For example, between tablet and phone, the edges of the cards start going off the screen.

Instead of using mixins to statically define widths, can you create flexible layouts? Here's how you'd implement that at a high level:

  • Notice for the mobile design, the entire page has the same width padding (16px on each side). You can give the .page class a mixin for mobile that applies 16px width padding for the entire page.
  • For every other component, have it stretch to take up the entire width. Then when the screen size changes, the width of the component will change dynamically and take up the entire width it's allowed within the padding. This will happen automatically if you use a column flexbox and align-items: stretch; for the page.

Let me know if you have any questions or need help getting this done!

@C3viche C3viche changed the title Added mobile css Clinic Schedules Page Mobile Layout Mar 23, 2025
Copy link
Collaborator

@C3viche C3viche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed and approved

@C3viche C3viche merged commit 34881fb into main Mar 25, 2025
1 check passed
@C3viche C3viche deleted the 31-clinic-schedules-mobile branch March 25, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clinic Schedules Mobile

4 participants