Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the common.StructToMap helper to omit fields explicitly ignored via JSON tags (e.g., metadata fields like XMLName), preventing them from appearing in map-converted API payloads.
Changes:
- Skip struct fields tagged with
json:"-"when converting a struct tomap[string]any. - Add unit test coverage to ensure
json:"-"fields are omitted.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
broker/common/common.go |
Updates StructToMap to ignore json:"-" fields. |
broker/common/common_test.go |
Adds a test ensuring ignored fields (e.g., XMLName) are skipped. |
Comments suppressed due to low confidence (1)
broker/common/common.go:39
StructToMaptreats anyjsontag with options (i.e. containing a comma) as an explicit field name, butjson:",omitempty"(empty name) is valid and should fall back to the struct field name perencoding/jsonrules. As written, this would produce an empty-string map key. Consider only overridingfieldNamewith the part before the comma when that part is non-empty (and not "-").
before, _, found := strings.Cut(jsonTag, ",")
if before == "-" {
continue
}
if found {
fieldName = before
} else {
fieldName = jsonTag
}
JanisSaldabols
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.