Preserve user provided ILL request, only force sensitive fields#484
Merged
Preserve user provided ILL request, only force sensitive fields#484
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the borrowing “send request” flow so outgoing ISO18626 requests preserve user-supplied fields while still enforcing broker-controlled/sensitive header and patron identifiers.
Changes:
- Build the outgoing ISO18626
Requestby starting from the stored/user-provided request instead of reconstructing a minimal request. - Force
RequestingAgencyId,RequestingAgencyRequestId, andPatronInfo.PatronIdonto the outgoing request. - Add a unit test to validate preserved fields on the outgoing request.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
broker/patron_request/service/action.go |
Changes sendBorrowingRequest to reuse the provided iso18626.Request and overwrite sensitive fields. |
broker/patron_request/service/action_test.go |
Adds a test asserting non-sensitive fields are preserved in the outgoing request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.