-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ V2 Rewrite — Get rid of lz4 dependency #7
Conversation
Also replace Travis CI with Github Actions.
I've just published this to NPM. This is now available to install with —
@Prsna23 @ankon @Freakachoo Can you folks let me know if this beta version works for you? |
@paambaati I don't think we will be upgrading it for a while now. I am able to pull this package without a problem. |
We replaced kafkajs-lz4 with a simple trivial wrapper based on #2. I'll have to check whether switching to lz4-asm would be worth the effort for us, but it's definitely nice to see activity here! |
The
lz4
package has installation issues, and seems to be not maintained anymore.This PR aims to remove this dependency entirely and instead use
lz4-asm
. It is actively maintained and offers near-native performance.This PR should fix #5 and #3
Other changes include —
lz4-asm
).Rollout strategy
We'll be publishing this as a a beta (
yarn add [email protected]
), collect feedback and then promote2.0.0
to stable after a few weeks.@Prsna23 Can you also upgrade to this internally and ensure this is stable?
CC: @ankon @Freakachoo