Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of star expression in index #926

Closed
wants to merge 1 commit into from

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Mar 23, 2025

Reported by ruff 0.11.2. I'm not sure the variable names make sense, so feedback very welcome.

Also just noticed that there's a firedrake failure :(

@connorjward
Copy link
Contributor

I'll fix the Firedrake issue on Monday. A small change was made to our containers.

@alexfikl
Copy link
Contributor Author

I'll fix the Firedrake issue on Monday. A small change was made to our containers.

That would be lovely, thanks! Feel free to cherry pick this commit in there or however you want to handle it.

@connorjward
Copy link
Contributor

see #927

inducer added a commit that referenced this pull request Mar 24, 2025
@inducer
Copy link
Owner

inducer commented Mar 24, 2025

This is a bug in ruff: astral-sh/ruff#16943, with a fix already merged. #928 should make avoiding buggy dev dependencies easier in the future.

@inducer inducer closed this Mar 24, 2025
@alexfikl
Copy link
Contributor Author

This is a bug in ruff: astral-sh/ruff#16943, with a fix already merged. #928 should make avoiding buggy dev dependencies easier in the future.

Ah, cool! I didn't know there was a difference between parenthesized or not and thought they were both disallowed :\

@inducer
Copy link
Owner

inducer commented Mar 24, 2025

It's not "parenthesis vs not", the parentheses make it a tuple literal.

@alexfikl alexfikl deleted the fix-star-index branch March 24, 2025 19:18
inducer added a commit that referenced this pull request Mar 25, 2025
inducer added a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants