More typing in geometric_algebra #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Nov 13, 2024
alexfikl
commented
Nov 13, 2024
alexfikl
commented
Nov 13, 2024
alexfikl
force-pushed
the
geometric-algebra-typing
branch
from
a5dd96f to
df069e3
Compare
3 tasks
inducer
force-pushed
the
geometric-algebra-typing
branch
from
df069e3 to
13639e4
Compare
inducer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types some more things mainly in
geometric_algebra/__init__.py.At least typing
componentwiseseems to cause more errors inpytential, so yey!EDIT: As far as I can tell, the errors in
pytentialare legitimate, i.e. it complains that some__new__implementations returnnp.ndarraysinstead of the type itself e.g.https://github.com/inducer/pytential/blob/bc941d32231a2edd1ed8c402f3cf23e1eb59af58/pytential/symbolic/primitives.py#L480-L486