Rename type aliases for consistency #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
force-pushed
the
rename-type-aliases
branch
5 times, most recently
from
ea1509d to
a6049ac
Compare
|
That's probably it in terms of compatibility impact. Other than a better name for |
alexfikl
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Looks good to me too!
Not sure if I can come up with a better than ExpressionOrData though.
ExpressionOrScalar? (is there other "data" you had in mind?)NestedExpression? (because of the recursive typevar?)- Not sure it's a good idea to go very general here with something like
NodeorSymbolicNode,ExpressionNode?
inducer
force-pushed
the
rename-type-aliases
branch
from
a6049ac to
cce6625
Compare
inducer
commented
Nov 21, 2024
inducer
force-pushed
the
rename-type-aliases
branch
from
cce6625 to
c972660
Compare
inducer
force-pushed
the
rename-type-aliases
branch
from
c972660 to
ce6dc1e
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was straightforward enough to make with pyright's symbol rename support. I'm not sure I fully understand the compatibility implications.
module_getattr_for_deprecationspytools#268 and a pytools release