Add equality test #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Apr 30, 2022
alexfikl
force-pushed
the
add-equality-test
branch
2 times, most recently
from
6f62904 to
a9a56d4
Compare
inducer
reviewed
May 2, 2022
alexfikl
force-pushed
the
add-equality-test
branch
from
a9a56d4 to
d2364df
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for the equality as suggested in #74 (comment).
Setting
depth=16still works, butdepth=32starts hanging and it just gets worse from there. Also tested this on #74 and it fixes the issue, but thought I'd add it tomainfirst.This also contains some vim markers and using
logginginstead ofprintin there, as a small cleanup.