Refactor E2P and P2E #153
Merged
Refactor E2P and P2E #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
force-pushed
the
e2p
branch
17 times, most recently
from
99c3834 to
ce6b448
Compare
isuruf
force-pushed
the
e2p
branch
4 times, most recently
from
c8524ee to
7c6a0d7
Compare
|
Thanks for working on this! This (and the corresponding pytential branch) LGTM. I've pushed a commit with some renaming and light-duty type annotation. I hope you're OK with both, if not, scream soon! 🙂 (because I'm planning on merging this as soon as everything passes) |
|
Renaming looks good. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Add option to disable check_implemented_domains loopy#736