-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: fix: consolidate http-client trees in a compatible way with use across fluvio repo #3585
Conversation
surf
client to address security alertsurf
client to address security alert
I don't mind the hyper-client per se, in the past there might have been some async compatibility issues that cropped up at runtime so we need to recheck that by doing a fluvio install to a k8 cluster. The CI does that, but it's probably worth trying that locally. |
6660885
to
05304b3
Compare
BTW, Hyper can work with std. see: https://github.com/infinyon/k8-api/blob/master/src/k8-client/src/client/mod.rs |
6150655
to
5a18654
Compare
5a18654
to
b064182
Compare
Summarizing, the security alert is related to two crates we're using,
Even more alarming, The current PR is using |
Please see my comment about |
surf
client to address security alert
Work will continue for this from a crate hosted at https://github.com/infinyon/fluvio-mini-http The crate should use hyper + rustls + async-std for improved compatibility & maintainabilty with our codebase and cross platform builds |
Good work |
bot alerted about a possible CPU denial of service in versions previous to
0.22.1
of thewebpki
crate.This crate was in the dependency tree of
http-client
andsurf
when using theh1-client-tls
feature.I removed the
http-client
dependency, as we're not using it, and changed thesurf
client tohyper-client
instead ofh1-client-tls
(the other option was to usecurl-client
).Closes https://github.com/infinyon/roadmap/issues/182