Overriding Accept-Encoding header when gzip is disabled #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When gzip is disabled, do not add Accept-Encoding header to request. (Overrided with identity for Accept-Encoding) - In specific environments/deployments the addition of this encoding type causes issues
|
Hi, got your point, can you please add a test that ensures the correctness of the resulting header in this case, a additional entry in the CHANGELOG.md would also be nice. |
|
Any updates here ? |
|
Sorry, I haven't had the time to figure out to implement a test for this. It wasn't as straight forward as I initially thought. If you have any ideas on how to test this it would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.