Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(linters): Enable testifylint: blank-import, float-compare, negative-positive, nil-compare and useless-assert #15566

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

zak-pawel
Copy link
Collaborator

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15533
resolves #15534
resolves #15536
resolves #15537
resolves #15538

…ive-positive, nil-compare and useless-assert
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 26, 2024
@mstrandboge mstrandboge removed their assignment Jun 26, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel for going through all those files! Two comments from my side and a request to define the delta 0.001 as a constant in the testutil package so we can reduce the delta if required...

@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel!

@srebhan srebhan merged commit 1422c09 into influxdata:master Jul 1, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.1 milestone Jul 1, 2024
srebhan pushed a commit that referenced this pull request Jul 1, 2024
… `negative-positive`, `nil-compare` and `useless-assert` (#15566)

(cherry picked from commit 1422c09)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test
Projects
None yet
4 participants