-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(linters): Enable testifylint
: blank-import
, float-compare
, negative-positive
, nil-compare
and useless-assert
#15566
Conversation
…ive-positive, nil-compare and useless-assert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel for going through all those files! Two comments from my side and a request to define the delta 0.001
as a constant in the testutil
package so we can reduce the delta if required...
plugins/inputs/google_cloud_storage/google_cloud_storage_test.go
Outdated
Show resolved
Hide resolved
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel!
Summary
Checklist
Related issues
resolves #15533
resolves #15534
resolves #15536
resolves #15537
resolves #15538