chore(outputs.sql): Update ClickHouse Docker image for integration test #16462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
area/sql
chore
plugin/output
1 task
AndreKR
changed the title
AndreKR
force-pushed
the
clickhouse-test-image-update
branch
from
85016bb to
c86f67f
Compare
The Docker image `yandex/clickhouse-server` that has been used for the integration test hasn't been updated in 3 years. ClickHouse has moved to the Docker image that is called `clickhouse`. This uses the new image for the integration test. The log messages have changed, so that is taken into account when waiting for the test container to spin up. Technically waiting for the open port would be enough but for good measure we also wait for a corresponding log output. To get the log output, a config file is included.
AndreKR
force-pushed
the
clickhouse-test-image-update
branch
from
c86f67f to
a4d3e5d
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
Feb 6, 2025
srebhan
added
the
ready for final review
1 task
DStrand1
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Docker image
yandex/clickhouse-serverthat has been used for the integration test hasn't been updated in 3 years. ClickHouse has moved to the Docker image that is calledclickhouse.This uses the new image for the integration test.
The log messages have changed, so that is taken into account when waiting for the test container to spin up. Technically waiting for the open port would be enough but for good measure we also wait for a corresponding log output. To get the log output, a config file is included.
Checklist
Related issues
resolves #16461