Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.sql): Fix insert into ClickHouse #16472

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

AndreKR
Copy link
Contributor

@AndreKR AndreKR commented Feb 4, 2025

Summary

The clickhouse-go database driver does not like an INSERT without a space after the table name. (ClickHouse/clickhouse-go#1485) This works around that issue by inserting a space there, which is completely valid SQL as well.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16471

The clickhouse-go database driver does not like an INSERT without a
space after the table name. This works around that issue by inserting a
space there, which is completely valid SQL as well.
@telegraf-tiger telegraf-tiger bot added area/sql fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Feb 4, 2025
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 4, 2025

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndreKR!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 4, 2025
@DStrand1 DStrand1 merged commit 1b2e012 into influxdata:master Feb 5, 2025
27 checks passed
@github-actions github-actions bot added this to the v1.33.2 milestone Feb 5, 2025
@AndreKR AndreKR deleted the fix-clickhouse-insert branch February 9, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "expected ... arguments, got ..." in SQL output plugin with ClickHouse
3 participants