OSPRH-16753: Converge tests based on enabled features #275

MiguelCarpio · 2025-06-02T11:32:53Z

Converge the following tests based on enabled features

autoscaling
graphing

Depends-On: openstack-k8s-operators/telemetry-operator#696

softwarefactory-project-zuul · 2025-06-02T12:51:29Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bc6f82e76d23449e9466de93d4537f53

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 17m 14s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 03m 44s
❌ functional-logging-tests-osp18 FAILURE in 59m 13s
❌ functional-graphing-tests-osp18 FAILURE in 1h 01m 22s (non-voting)

softwarefactory-project-zuul · 2025-06-02T14:30:05Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3785f304595a4596939682f1b0621d35

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 16m 36s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 02m 56s
❌ functional-logging-tests-osp18 FAILURE in 1h 02m 00s
❌ functional-graphing-tests-osp18 FAILURE in 1h 01m 44s (non-voting)

softwarefactory-project-zuul · 2025-06-02T16:07:59Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/975fcf27071f481387790d8187b30e84

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 15m 34s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 02m 07s
❌ functional-logging-tests-osp18 FAILURE in 59m 45s
❌ functional-graphing-tests-osp18 FAILURE in 1h 00m 09s (non-voting)

softwarefactory-project-zuul · 2025-06-02T18:43:53Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/56d2d6b1c80647a5baf5bd38bb65a456

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 02s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 04m 17s
❌ functional-logging-tests-osp18 FAILURE in 1h 05m 21s
❌ functional-graphing-tests-osp18 FAILURE in 1h 03m 15s (non-voting)

softwarefactory-project-zuul · 2025-06-03T00:09:33Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c9283d8c0ac8407fa6d0fe58af253e36

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 27m 54s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 26m 21s
❌ functional-logging-tests-osp18 FAILURE in 1h 05m 32s
❌ functional-graphing-tests-osp18 TIMED_OUT in 3h 12m 54s (non-voting)

softwarefactory-project-zuul · 2025-06-03T10:32:43Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ed8bb4f450374d91922c3828853b4566

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 29s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 27m 08s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 11m 47s
❌ functional-graphing-tests-osp18 FAILURE in 1h 38m 52s (non-voting)

softwarefactory-project-zuul · 2025-06-03T15:10:53Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/05999691d7c84e5b9f4801eaa621c95f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 00s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 04m 20s
❌ functional-logging-tests-osp18 FAILURE in 1h 01m 48s
❌ functional-graphing-tests-osp18 FAILURE in 1h 06m 15s (non-voting)

softwarefactory-project-zuul · 2025-06-03T18:52:33Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0823578f8ac040fd8b1b5852f23abd12

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 31m 55s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 30m 44s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 16m 12s
❌ functional-graphing-tests-osp18 TIMED_OUT in 3h 13m 44s (non-voting)

elfiesmelfie · 2025-06-03T20:06:54Z

ci/logging_tests_computes.yml

@@ -18,10 +18,12 @@
    - name: "Run Telemetry Logging tests"
      ansible.builtin.import_role:
        name: telemetry_logging
+      when: hostvars['localhost'].enable_logging_role | bool


Instead of guarding each task, you could use some pre_tasks to skip this play if the variable is false.

Here's an example:

feature-verification-tests/ci/report_result.yml

Lines 62 to 66 in e855781

pre_tasks:

- name: Stop play early if we do not want to check the failures

when:

- not (check_failures | default(true) | bool)

ansible.builtin.meta: end_play

elfiesmelfie · 2025-06-03T20:07:25Z

ci/logging_tests_computes.yml

@@ -18,10 +18,12 @@
    - name: "Run Telemetry Logging tests"
      ansible.builtin.import_role:
        name: telemetry_logging
+      when: hostvars['localhost'].enable_logging_role | bool


I would prefer some other name, like logging_enabled or logging_features_enabled, but that's up for debate

elfiesmelfie · 2025-06-03T20:09:14Z

ci/run_cloudops_tests_osp18.yml

Same feedback here for the pre_tasks. It will reduce the size of the change, and reduce the possibility of errors later, if new tasks are needed for the autoscaling tests, for example.

elfiesmelfie · 2025-06-03T20:12:39Z

ci/run_cloudops_tests_osp18.yml

@@ -13,10 +13,12 @@
        - name: Include vars from the extra_vars files
          ansible.builtin.include_vars:
            dir: "{{ cifmw_basedir }}/artifacts/parameters"
+          when: hostvars['localhost'].enable_autoscaling_role | bool


Guarding the block is sufficient here. The individual task don't need to be guarded.

elfiesmelfie · 2025-06-03T20:18:33Z

ci/run_fvt_tests.yml

If going with the approach of using pre_tasks (as suggested above), then the check for each set of tests could happen in the pre_task section of the play.

There's an alternative approach where the tests are in one large playbook, with multiple plays that will detect whether the particular features are enabled, then try to run all the tests, with guarding in the appropriate place.

softwarefactory-project-zuul · 2025-06-04T12:38:11Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/878a9bbe4f5d4ed2b70c374414688cc7

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 40s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 41m 49s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 15m 28s
❌ functional-graphing-tests-osp18 RETRY_LIMIT in 2m 59s (non-voting)

softwarefactory-project-zuul · 2025-06-04T16:25:58Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a314b27fc5814757b28ca74ccd4601a4

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 32m 22s
❌ functional-autoscaling-tests-osp18 FAILURE in 36m 39s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 12m 27s
❌ functional-graphing-tests-osp18 TIMED_OUT in 3h 14m 38s (non-voting)

softwarefactory-project-zuul · 2025-06-05T12:02:41Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1b790b56ab794be3a32f8c9af7b0d295

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 29s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 23m 42s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 14m 15s
❌ functional-graphing-tests-osp18 FAILURE in 1h 20m 10s (non-voting)

softwarefactory-project-zuul · 2025-06-11T18:17:34Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a8d56a905d5642bbad01aa3aa42daed5

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 01m 43s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 08m 18s
❌ functional-logging-tests-osp18 FAILURE in 1h 40m 41s
❌ functional-graphing-tests-osp18 FAILURE in 1h 07m 45s (non-voting)

softwarefactory-project-zuul · 2025-06-11T21:40:49Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/44b8d8ead7f446f6b6204cd90e4330ae

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 58s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 04m 32s
❌ functional-logging-tests-osp18 FAILURE in 1h 38m 13s
❌ functional-graphing-tests-osp18 FAILURE in 1h 04m 06s (non-voting)

softwarefactory-project-zuul · 2025-06-12T09:17:20Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df73bca68c0b46d6a463b9341ccec9ea

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 55s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 04m 20s
❌ functional-logging-tests-osp18 FAILURE in 1h 41m 15s
❌ functional-graphing-tests-osp18 FAILURE in 1h 01m 40s (non-voting)

softwarefactory-project-zuul · 2025-06-12T11:41:18Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/02117aaf34fc4483be6ebbdd62bc1803

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 15s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 04m 31s
❌ functional-logging-tests-osp18 FAILURE in 1h 39m 07s
❌ functional-graphing-tests-osp18 FAILURE in 1h 01m 05s (non-voting)

softwarefactory-project-zuul · 2025-06-12T14:27:29Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3acaa7b1a2804525bce5e11bc79eeb52

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 43s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 05m 13s
❌ functional-logging-tests-osp18 FAILURE in 1h 39m 29s
❌ functional-graphing-tests-osp18 FAILURE in 1h 07m 33s (non-voting)

softwarefactory-project-zuul · 2025-06-12T16:38:13Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/171d52d383204608a719a1b72fbb0446

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 44s
❌ functional-autoscaling-tests-osp18 FAILURE in 1h 02m 29s
❌ functional-logging-tests-osp18 FAILURE in 1h 40m 36s
❌ functional-graphing-tests-osp18 FAILURE in 1h 04m 29s (non-voting)

MiguelCarpio force-pushed the OSPRH-16753 branch from 8b6c80b to 6f7f48c Compare June 2, 2025 13:12

MiguelCarpio force-pushed the OSPRH-16753 branch from 6f7f48c to b417449 Compare June 2, 2025 14:51

MiguelCarpio force-pushed the OSPRH-16753 branch from b417449 to 0c8f7a3 Compare June 2, 2025 17:22

MiguelCarpio force-pushed the OSPRH-16753 branch from 0c8f7a3 to 842bd03 Compare June 2, 2025 20:40

MiguelCarpio force-pushed the OSPRH-16753 branch 2 times, most recently from ff4c733 to 76eae50 Compare June 3, 2025 08:39

MiguelCarpio force-pushed the OSPRH-16753 branch 4 times, most recently from f0c084d to c03852a Compare June 3, 2025 13:49

MiguelCarpio force-pushed the OSPRH-16753 branch from c03852a to 88752e9 Compare June 3, 2025 15:19

elfiesmelfie reviewed Jun 3, 2025

View reviewed changes

MiguelCarpio force-pushed the OSPRH-16753 branch 2 times, most recently from cafbf53 to b17f5eb Compare June 4, 2025 10:39

MiguelCarpio force-pushed the OSPRH-16753 branch from b17f5eb to fd93c31 Compare June 4, 2025 12:51

MiguelCarpio force-pushed the OSPRH-16753 branch from ad3ad02 to 11751b1 Compare June 5, 2025 10:11

MiguelCarpio force-pushed the OSPRH-16753 branch from 11751b1 to 703620c Compare June 11, 2025 16:13

MiguelCarpio force-pushed the OSPRH-16753 branch from 703620c to e7b26ba Compare June 11, 2025 19:42

MiguelCarpio force-pushed the OSPRH-16753 branch from e7b26ba to 106945a Compare June 12, 2025 07:13

MiguelCarpio force-pushed the OSPRH-16753 branch from 19dd5ab to b83b6c7 Compare June 12, 2025 09:43

[ci] Converge tests based on enabled features

f2d40c7

MiguelCarpio force-pushed the OSPRH-16753 branch from b83b6c7 to f2d40c7 Compare June 12, 2025 12:28

Use pre_tests

d5ca6f9

	pre_tasks:
	- name: Stop play early if we do not want to check the failures
	when:
	- not (check_failures \| default(true) \| bool)
	ansible.builtin.meta: end_play

OSPRH-16753: Converge tests based on enabled features #275

Are you sure you want to change the base?

OSPRH-16753: Converge tests based on enabled features #275

Uh oh!

Conversation

MiguelCarpio commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Jun 2, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 2, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 2, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 2, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 3, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 3, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 3, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 3, 2025

Uh oh!

elfiesmelfie Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

elfiesmelfie Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

elfiesmelfie Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

elfiesmelfie Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

elfiesmelfie Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Jun 4, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 4, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 5, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 11, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 11, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 12, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 12, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 12, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 12, 2025

Uh oh!

Uh oh!

MiguelCarpio commented Jun 2, 2025 •

edited

Loading