fix: make retry attempts respect current slot number #108
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dylanlott
force-pushed
the
prestwich/bumpable-prep
branch
from
0d88be1 to
72d2c26
Compare
dylanlott
force-pushed
the
dylan/fix-retry-slot-checks
branch
3 times, most recently
from
449e320 to
ff22657
Compare
dylanlott
force-pushed
the
prestwich/bumpable-prep
branch
from
48a1e82 to
4f0445e
Compare
dylanlott
force-pushed
the
dylan/fix-retry-slot-checks
branch
from
ff22657 to
4bc36fa
Compare
dylanlott
force-pushed
the
prestwich/bumpable-prep
branch
from
4f0445e to
ecc8355
Compare
dylanlott
force-pushed
the
dylan/fix-retry-slot-checks
branch
from
4bc36fa to
57614e4
Compare
dylanlott
force-pushed
the
dylan/fix-retry-slot-checks
branch
from
57614e4 to
1e75f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: make retry attempts respect current slot number
Retry attempts were happening but if the slot changed in the middle of a retry attempt, it wouldn't recognize it and would get into an error loop, exhausting all retry attempts on an obviously incorrect block.
Instead, this PR checks the initial slot number and each retry attempt will only happen if the slot is still valid.
Closes ENG-1127