-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wrapped fzaar #280
Conversation
WalkthroughThe pull request updates the asset list configuration by adding a new entry for "Wrapped fZAAR." This entry includes a detailed structure with denomination units, base, display name, symbol, trace information for both wrapped and IBC types, and image/logo URIs. The modifications ensure the asset is properly represented in the system with all necessary metadata. Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying registry-initiation-1 with
|
Latest commit: |
657a28f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://a05650ff.registry-initiation-1.pages.dev |
Branch Preview URL: | https://feat-wrapped-fzaar.registry-initiation-1.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
testnets/initia/assetlist.json (1)
402-403
: Optional: Populate coingecko_id if available
Currently, the "coingecko_id" field is an empty string. If the wfZAAR token is listed on Coingecko, consider adding the corresponding ID to this field. This enhancement would improve the asset’s integration with pricing and market data tools.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
testnets/initia/assetlist.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages: registry-initiation-1
🔇 Additional comments (1)
testnets/initia/assetlist.json (1)
385-437
: New asset entry for "Wrapped fZAAR" is structured correctly
The new asset entry includes all the essential fields—such as "description", "denom_units" (with both the IBC denom and the wfZAAR variant), "base", "display", "name", "symbol", and detailed "traces" for both wrapped and IBC types—as well as the image and logo URIs. Please double-check that the chain parameters (e.g., contract address, channel id, and path) are correct to ensure smooth integration with downstream systems.
Deploying registry-devnet with
|
Latest commit: |
657a28f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://6866bd50.registry-devnet.pages.dev |
Branch Preview URL: | https://feat-wrapped-fzaar.registry-devnet.pages.dev |
Deploying registry-testnet with
|
Latest commit: |
657a28f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://58a638d9.initia-registry-testnets.pages.dev |
Branch Preview URL: | https://feat-wrapped-fzaar.initia-registry-testnets.pages.dev |
add wfZAAR token
Summary by CodeRabbit