Skip to content

Conversation

@Piyush7034
Copy link
Contributor

@Piyush7034 Piyush7034 commented Jan 14, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced internal logging to improve debugging and diagnostic capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Walkthrough

Two debug logging statements were added to the fetchData method in IdaDataProviderPluginImpl.java to log encrypted KYC data and JWT claims. No functional changes or control flow modifications were introduced.

Changes

Cohort / File(s) Summary
Debug Logging Enhancement
mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java
Added two debug log statements: encrypted KYC data and JWT claims inspection in the fetchData method

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit hops with glee so bright,
Adding logs to debug the night,
KYC encrypted, claims in view,
Now troubleshooting's easier to do!
thump thump 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding debug logging statements to the IdaDataProviderPluginImpl class.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java`:
- Around line 105-107: The current debug log writes full decoded KYC claims
(variable claims from decodeClaimsFromJwt) which may contain PII; in
IdaDataProviderPluginImpl remove or replace that log so sensitive values are not
written: either delete the log.debug("JWT Claims: {}", claims) call, or log only
non-sensitive metadata such as claims.keySet() or claims.size(), or explicitly
redact sensitive keys (name, dob, id numbers, address) before any logging;
update any tests or callers that rely on the full-claims log accordingly.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0239ba and d798010.

📒 Files selected for processing (1)
  • mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: Piyush7034
Repo: inji/digital-credential-plugins PR: 130
File: mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java:189-197
Timestamp: 2026-01-12T17:24:47.275Z
Learning: In the mosip-identity-certify-plugin, the `ACCESS_TOKEN_HASH` key is guaranteed to be present in the `identityDetails` map passed to `IdaDataProviderPluginImpl.doKycExchange()` because it is validated/included by the main service before this method is called. No null check is required for this key.
Learnt from: Piyush7034
Repo: inji/digital-credential-plugins PR: 130
File: mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java:226-229
Timestamp: 2026-01-12T17:25:34.301Z
Learning: In the mosip-identity-certify-plugin, when building KYC exchange requests in `IdaDataProviderPluginImpl.kycExchange()`, the Authorization header is intentionally set to the literal string "Authorization" (value of AUTHORIZATION_HEADER_NAME constant) rather than an actual token. This is the correct implementation verified to work with the IDA service.
📚 Learning: 2026-01-12T17:25:25.933Z
Learnt from: Piyush7034
Repo: inji/digital-credential-plugins PR: 130
File: mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java:226-229
Timestamp: 2026-01-12T17:25:25.933Z
Learning: In IdaDataProviderPluginImpl.kycExchange() within mosip-identity-certify-plugin, the Authorization header should be set to the literal string "Authorization" (i.e., the value of AUTHORIZATION_HEADER_NAME) rather than a real token. This exact approach has been verified to work with the IDA service. Do not replace with a bearer token or dynamic value in this path.

Applied to files:

  • mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java
📚 Learning: 2026-01-12T17:24:47.275Z
Learnt from: Piyush7034
Repo: inji/digital-credential-plugins PR: 130
File: mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java:189-197
Timestamp: 2026-01-12T17:24:47.275Z
Learning: In the mosip-identity-certify-plugin, the `ACCESS_TOKEN_HASH` key is guaranteed to be present in the `identityDetails` map passed to `IdaDataProviderPluginImpl.doKycExchange()` because it is validated/included by the main service before this method is called. No null check is required for this key.

Applied to files:

  • mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java
📚 Learning: 2025-12-31T13:55:27.155Z
Learnt from: Piyush7034
Repo: inji/digital-credential-plugins PR: 123
File: postgres-dataprovider-plugin/src/main/java/io/mosip/certify/postgresdataprovider/integration/service/PostgresDataProviderPlugin.java:50-56
Timestamp: 2025-12-31T13:55:27.155Z
Learning: In the digital-credential-plugins repository, different data provider plugins use different error codes based on their data source: PostgresDataProviderPlugin uses "ERROR_FETCHING_DATA_RECORD_FROM_TABLE" for database operations, while MockIdaDataProviderPlugin and MockCSVDataProviderPlugin use "ERROR_FETCHING_IDENTITY_DATA" for identity service and CSV operations. This distinction is intentional to improve debugging clarity.

Applied to files:

  • mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-maven-sunbird-rc-esignet-integration-impl / maven-build
  • GitHub Check: build-maven-mock-certify-plugin / maven-build
  • GitHub Check: build-maven-mosip-identity-certify-plugin / maven-build
  • GitHub Check: build-maven-postgres-dataprovider-plugin / maven-build

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

@swatigoel swatigoel merged commit adc8d2a into inji:develop Jan 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants