Skip to content

Conversation

@swatigoel
Copy link

@swatigoel swatigoel commented Jan 21, 2026

Summary by CodeRabbit

  • New Features

    • Added new data provider integration for KYC exchange capabilities.
  • Deprecations

    • Marked legacy VCI plugin components as deprecated; migration to new data provider path recommended.
  • Chores

    • Migrated organization namespace and updated project coordinates.
    • Updated build configuration for central Maven repository publishing.
    • Updated dependencies: esignet upgraded to 1.6.2.
    • Enhanced test coverage for plugin implementations.

✏️ Tip: You can customize this high-level summary in your review settings.

Piyush7034 and others added 9 commits June 26, 2025 09:28
[INJICERT-1298] Update groupId to publish certify plugins to new group io.inji
* [INJICERT-1298] Update pom version to RC1 to test maven publish

Signed-off-by: Swati Goel <[email protected]>

* [INJICERT-1298] Delete unused plugin sunbird-rc-esignet-integration-impl

Signed-off-by: Swati Goel <[email protected]>

* Revert "[INJICERT-1298] Delete unused plugin sunbird-rc-esignet-integration-impl"

This reverts commit 7643f28.

Signed-off-by: Swati Goel <[email protected]>

---------

Signed-off-by: Swati Goel <[email protected]>
* Revert "[INJICERT-1298] Update pom version to RC1 (#125)"

This reverts commit f566678.

Signed-off-by: Swati Goel <[email protected]>

* [INJICERT-1298] Update github repo references to github.com/inji

Signed-off-by: Swati Goel <[email protected]>

---------

Signed-off-by: Swati Goel <[email protected]>
#130)

* Rebased commit
[INJICERT-1295] Update mosipid plugin mode to dataprovider (#127)

* [INJICERT-1295] Update mosipid plugin mode to dataprovider

Signed-off-by: Piyush7034 <[email protected]>

* [INJICERT-1295] Update RC to SNAPSHOT for all pom files

Signed-off-by: Piyush7034 <[email protected]>

---------

Signed-off-by: Piyush7034 <[email protected]>

* [INJICERT-1298] Update certify org from mosip to inji (#128)

Signed-off-by: Piyush7034 <[email protected]>

* [INJICERT-1295] Add accepted kyc claims as config (#129)

Signed-off-by: Piyush7034 <[email protected]>

* [INJICERT-1295] Remove kyc data logs and add locale config

Signed-off-by: Piyush7034 <[email protected]>

* [INJICERT-1295] Fix typo in comment

Signed-off-by: Piyush7034 <[email protected]>

* [INJICERT-1295] Refactor mopsip id plugin project

Signed-off-by: Piyush7034 <[email protected]>

* [INJICERT-1295] Revert methods and changes int VCIHelperService

Signed-off-by: Piyush7034 <[email protected]>

---------

Signed-off-by: Piyush7034 <[email protected]>
@swatigoel swatigoel marked this pull request as draft January 21, 2026 09:33
@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This PR rebrand Maven coordinates from io.mosip.certify to io.inji.certify, bump versions from 0.4.0-SNAPSHOT to 0.6.0-SNAPSHOT, migrate from Nexus staging to central publishing infrastructure, and introduce a new Data Provider plugin architecture pattern alongside deprecated VCI components.

Changes

Cohort / File(s) Summary
Publishing & Maven Configuration
.github/workflows/push-trigger.yml, mock-certify-plugin/pom.xml, mosip-identity-certify-plugin/pom.xml, postgres-dataprovider-plugin/pom.xml, sunbird-rc-certify-integration-impl/pom.xml, sunbird-rc-esignet-integration-impl/pom.xml
Unified rebranding from io.mosip.certify to io.inji.certify across all pom.xml files; version bumps (0.4.0 → 0.6.0-SNAPSHOT); migration from Sonatype Nexus staging plugin to central publishing Maven plugin; repository/distribution URLs updated from oss.sonatype.org to central.sonatype.com; workflow secret reference changed from OSSRH_SNAPSHOT_URL to OSSRH_CENTRAL_URL.
New Data Provider Plugin & DTOs
mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaDataProviderPluginImpl.java, mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/dto/IdaKycExchangeRequest.java, mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/dto/IdaKycExchangeResponse.java
Introduces new IdaDataProviderPluginImpl implementing DataProviderPlugin interface with KYC exchange flow; adds IdaKycExchangeRequest and IdaKycExchangeResponse DTOs for IDA integration; supports encrypted individual ID retrieval, JWT signing, HTTP POST to IDA endpoint, and JWT claim decoding.
New Helper Services
mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/TransactionHelper.java, mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/VCIAuthTransactionHelper.java, mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/VCIHelperService.java
New TransactionHelper component retrieves OIDCTransaction from cache for Data Provider pattern; new deprecated VCIAuthTransactionHelper handles token caching and retrieval for VCI plugin; new deprecated VCIHelperService provides request signature and UTC time utilities, replaces older HelperService dependency in VCI flows.
VCI Plugin Deprecation & Rebranding
mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/AuthTransactionHelper.java, mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/VCITransactionHelper.java, mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaVCIssuancePluginImpl.java, mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/HelperService.java
Adds @Deprecated annotations to VCITransactionHelper and IdaVCIssuancePluginImpl; updates conditional property guards from vci-plugin to data-provider-plugin in AuthTransactionHelper and HelperService; changes IdaVCIssuancePluginImpl dependency from HelperService to VCIHelperService.
Dependency Injection & Configuration
mock-certify-plugin/src/main/java/io.mosip.certify.mock.integration/service/MDocMockVCIssuancePlugin.java
Introduces @Autowired MdocGenerator field to replace direct instantiation in MSO MDOC credential generation path.
Test Suite Expansion
mock-certify-plugin/src/test/java/io/mosip/certify/mock/integration/service/MDocMockVCIssuancePluginTest.java, mosip-identity-certify-plugin/src/test/java/io/mosip/certify/mosipid/integration/service/IdaAuditPluginImplTest.java, mosip-identity-certify-plugin/src/test/java/io/mosip/certify/mosipid/integration/service/IdaVCIssuancePluginImplTest.java, postgres-dataprovider-plugin/src/test/java/io/mosip/certify/postgresdataprovider/integration/service/PostgresDataProviderPluginTest.java, sunbird-rc-certify-integration-impl/src/test/java/io/mosip/certify/sunbirdrc/integration/service/SunbirdRCVCIssuancePluginTest.java
New MDocMockVCIssuancePluginTest with 11 test methods covering credential issuance, HSM key retrieval, and claim mocking; adds getter/setter tests to IdaAuditPluginImplTest; expands IdaVCIssuancePluginImplTest with DTO serialization tests; updates exception handling in PostgresDataProviderPluginTest; removes Spring Boot test context from SunbirdRCVCIssuancePluginTest.
Documentation Updates
postgres-dataprovider-plugin/README.md
Updates GitHub hyperlinks from mosip to inji namespace and adds explicit scope-query-mapping configuration block for credential scope SQL examples.

Sequence Diagram(s)

sequenceDiagram
    actor Client
    participant DataProvider as IdaDataProviderPluginImpl
    participant Request as IDA KYC Exchange
    participant Signer as SignatureService
    participant KeyStore as KeyManagement
    participant JWT as JWT Decoder
    
    Client->>DataProvider: fetchData(identityDetails)
    activate DataProvider
    DataProvider->>DataProvider: buildKycExchangeDto()
    DataProvider->>DataProvider: getIndividualId() / decrypt if secure
    alt Secure Mode Enabled
        DataProvider->>KeyStore: getKeyAlias(CURRENTKEYALIAS)
        KeyStore-->>DataProvider: encryptionKeyAlias
        DataProvider->>KeyStore: decrypt(individualId)
        KeyStore-->>DataProvider: decryptedIndividualId
    end
    DataProvider->>Signer: sign(IdaKycExchangeRequest)
    Signer-->>DataProvider: signature
    DataProvider->>Request: POST with signature header
    Request-->>DataProvider: IdaKycExchangeResponse(encryptedKyc)
    DataProvider->>JWT: decodeClaimsFromJwt(encryptedKyc)
    JWT-->>DataProvider: Map<String, Object> claims
    DataProvider-->>Client: JSONObject(claims)
    deactivate DataProvider
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested reviewers

  • ckm007
  • Prafulrakhade

Poem

🐰 From Mosip's embrace to Inji's bright home,
We hippity-hop through the provider's new roam,
KYC flows dance with signatures signed,
While VCI rests, deprecated but kind. 🌟

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@swatigoel swatigoel closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants