Skip to content

Conversation

@Piyush7034
Copy link
Contributor

@Piyush7034 Piyush7034 commented Jan 21, 2026

Summary by CodeRabbit

  • Chores
    • Removed the Sunbird RC eSignet integration implementation module and its associated build pipelines.
    • Removed CI/CD workflows for building, publishing, and analyzing the integration component.
    • Removed documentation, test resources, and Postman collection files related to the module.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

This PR completely removes the sunbird-rc-esignet-integration-impl module from the repository, including its Maven build configuration, GitHub Actions pipeline jobs, documentation, source code, tests, and test resources.

Changes

Cohort / File(s) Summary
CI/CD Pipeline
.github/workflows/push-trigger.yml
Removed three jobs: build-maven-sunbird-rc-esignet-integration-impl, publish_to_nexus_sunbird-rc-esignet-integration-impl, and sonar_analysis_sunbird-rc-esignet-integration-impl, eliminating the entire build-publish-analyze pipeline for this module.
Module Build Configuration
sunbird-rc-esignet-integration-impl/pom.xml
Complete removal of Maven POM file including project coordinates, dependencies, repositories, build plugins (maven-assembly, maven-javadoc, maven-deploy, central-publishing, maven-surefire, jacoco, etc.), and distribution management configuration.
Documentation
sunbird-rc-esignet-integration-impl/README.md, sunbird-rc-esignet-integration-impl/postman-collections/README.md
Deleted module README containing overview, configuration instructions, and property guidance; removed Postman collection documentation with usage instructions and crypto operations guidance.
Postman Resources
sunbird-rc-esignet-integration-impl/postman-collections/eSignet-with-Sunbird-RC.postman_collection.json
Removed entire Postman collection definition (~1098 lines) including OIDC client management, registry, KBA, well-known endpoints, OAuth workflows, and collection variables.
DTO Classes
sunbird-rc-esignet-integration-impl/src/main/java/io/mosip/esignet/sunbirdrc/integration/dto/{ReCaptchaError.java, ReCaptchaResponse.java, RegistrySearchRequestDto.java}
Deleted three data transfer objects: ReCaptchaError with errorCode/message fields, ReCaptchaResponse with success/challengeTs/hostname/errorCodes, and RegistrySearchRequestDto with offset/limit/filters.
Service Implementation
sunbird-rc-esignet-integration-impl/src/main/java/io/mosip/esignet/sunbirdrc/integration/service/SunbirdRCAuthenticationService.java
Removed complete Authenticator implementation including initialization logic, KYC authentication flow, knowledge-based authentication validation, registry search request building, and error handling.
Test Code
sunbird-rc-esignet-integration-impl/src/test/java/io/mosip/esignet/sunbirdrc/integration/service/SunbirdRCAuthenticaionServiceTest.java
Deleted entire test suite with mocks, initialization tests, and KYC authentication test cases (~291 lines).
Test Resources
sunbird-rc-esignet-integration-impl/src/test/resources/InsuranceCredential.json
Removed Velocity-templated test resource generating VerifiableCredential JSON with dynamic expiry dates and credential subject fields.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Suggested reviewers

  • swatigoel
  • ckm007

Poem

🐰 A module departs, clean and swift,
No trace of Sunbird RC left in drift,
Build jobs vanish, workflows take flight,
The codebase now sleek and light,
Hoppity-hop, simplicity reigns! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: removing the entire sunbird-rc-esignet plugin project, which aligns with the changeset that deletes all related files, workflows, and dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@swatigoel swatigoel merged commit aab5e33 into inji:develop Jan 23, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants