Skip to content

Update docker-compose.yaml#528

Open
DrinkMoreJuice wants to merge 32 commits intoinji:developfrom
DrinkMoreJuice:patch-1
Open

Update docker-compose.yaml#528
DrinkMoreJuice wants to merge 32 commits intoinji:developfrom
DrinkMoreJuice:patch-1

Conversation

@DrinkMoreJuice
Copy link

@DrinkMoreJuice DrinkMoreJuice commented Dec 9, 2025

This PR fixes a networking issue where the Redis service was not attached to the shared mosip_network, preventing Mimoto from connecting to Redis.

Redis is required for token caching and issuance-related session management. Because Redis was missing from the shared network, Mimoto could not resolve the hostname redis, resulting in connection errors.

The fix adds the Redis container to the shared network:

redis:
image: redis:alpine
ports:
- "6379:6379" volumes:
- redis-data:/data networks:
- network

With this change, Mimoto is now able to connect to Redis successfully, and the credential issuance flow operates correctly.

Summary by CodeRabbit

  • Chores
    • Updated Docker Compose configuration to connect Redis to the external network, improving service communication in containerized deployments.

✏️ Tip: You can customize this high-level summary in your review settings.

Piyush7034 and others added 30 commits October 15, 2025 17:02
Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
* [INJICERT-1246] Fix for status list vc issuance error

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Revert local config change

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
* [INJICERT-1246] Update credential-config.md file

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Update readme for revocation support

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Update v2 apis for ledger search and update status

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Update staus batch job update sequence diagram

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Update config properties in revocation md file

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…#481)

* [INJICERT-1246] Add critical code review changes

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Fixes for capacityInKB field change

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Fix ledger search filter

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Update fetching ledger search records based status list array

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1237] Add system info api collections and description for generateCSR refId (inji#476)

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Move stream logic to custom method for ledger search

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Add unit tests for ledger search V1 and V2

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…nji#484)

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
* [INJICERT-1249] Add upload CA certificate api

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1249] Add descriptions for CA certficate dto

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1249] Fix error msg and ca cert response format in api docs.

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1249] Fix apidocs format issue

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…ji#486)

* [INJICERT-1246] Remove status_value from status details in ledger

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Fix the upgrade and rollback script by prepending schema name

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
* [MOSIP-43485] Update junit and jupiter scope to test

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* Add version to junit dependencies

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* Upgrade jupiter

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…compose (inji#488)

* [INJICERT-1246] Update mimoto and web to the latest version

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Fix CORS issue

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Update docker readme with google auth steps reference

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Replace secrets and apis keys with env variables

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* Revert local file change

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* Removed mimoto bootstrap properties

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
* [INJICERT-1261] Add CORS enablement for svg-render endpoint

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1261] Add default value for cors enabled urls

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1261] Add description for cors enable config

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1261] Add cors property to docker-compose

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
)

* [INJICERT-1180] Fix rsa verification method

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1180] Fix rsa verification method unit test

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1180] Update context url for rsa verification method

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* Fix unit test for context change

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…liance (inji#494)

* [INJICERT-1262] Upgrade hibernate dependency version for license compliance

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* Add dependencies in management block

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…i#496)

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
* [INJICERT-1263] Update svgRenderTemplate readme

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1263] Add more details for svg render

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1263] Update plugin jar download link

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1263] Add points for updating didUrl for vc type

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1263] Add nginx proxy setup steps

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* Fix proxy name

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* Add actuator enablement for docker compose

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…nji#500)

* Mosip-43236 and Mosip-43235 - Automated V2 endpoints for Ledger search and status update  (inji#468)

* Mosip-43236 and mosip-43235

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

* mosip-43236

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

---------

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Co-authored-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

* Mosip-43236 and mosip-43235 (inji#479)

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Co-authored-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

* MOSIP-42259: Enable execution of a single test or task with all its required dependencies for INJI-CERTIFY. (inji#447)

* MOSIP-42259: Enable execution of a single test or task with all its required dependencies

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* MOSIP-42259

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* MOSIP-42259 Enable single testcase for execution with it's required dependency

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* MOSIP-42259 Updated the unique identifiers

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* MOSIP-42259 Changed the Unique Identifiers number for MockIDA and MosipID

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* MOSIP-42259 Removed the negative testcase additionaldependencies from EccR1

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* Updated the uniquieidentifier aslo in testcasedependency.json

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* Updated the json file

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* Updated testCaseInterDependency json file

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* Updated the unique identifier

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* Updated unique Identifier

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

* Updated unique identifier

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>

---------

Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>
Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

* Mosip-43621  - Automated CSR endpoints (Generate , Upload CA , Upload signed certificate) (inji#498)

* Mosip-43621

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

* mosip-43621

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

* mosip-43621

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

* mosip-43621

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

---------

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Co-authored-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

* Mosip-INJICERT-1256

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

---------

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Signed-off-by: SradhaMohanty5899 <mohantysradha10@gmail.com>
Co-authored-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Co-authored-by: Sradha Mohanty <mohantysradha10@gmail.com>
…i#501)

* [INJICERT-1268] Fixes in open-api-docs and docker default config

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1268] Fix upload-ca-certificate request body

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…nji#509)

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…nji#507)

* [INJICERT-1246] Update revocation, ledger and plugin design document

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1271] Add keymanager support docs

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1271] Add troubleshooting step for docker network issue

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1271] Update keymanager readme format and styling

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1271] Remove pusrposes header from keymanager readme file

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1271] Add few corrections in docs

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…inji#511)

* [INJICERT-1246] Add reference to postgres plugin setup in main readme

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

* [INJICERT-1246] Add descriptions for query terms

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>

---------

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
* [INJICERT-1271] - Add PKI support document

Signed-off-by: swatigoel <meet2swati@gmail.com>

* [INJICERT-1271] - Correct type attribute value for credentialStatus example in doc

Signed-off-by: swatigoel <meet2swati@gmail.com>

---------

Signed-off-by: swatigoel <meet2swati@gmail.com>
* [DSD-9080] inji-certify 0.12.2 release

Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>

* [DSD-9080] inji-certify 0.12.2 release

Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>

---------

Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
* Updated Pom version and Chart version for post-release changes

Signed-off-by: GitHub <noreply@github.com>

* [DSD-9375] inji-certify 0.13.0 post release

Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>

---------

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
Co-authored-by: Prafulrakhade <Prafulrakhade@users.noreply.github.com>
Co-authored-by: Praful Rakhade <prafulrakhade02@gmail.com>
…pts (inji#522)

Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
…ng to FAILED (inji#521)

* injicert-1279

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

* injicert-1281

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>

---------

Signed-off-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Co-authored-by: Likhitha R L <likhitha.rl@technoforte.co.in>
Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
abhishek8shankar and others added 2 commits December 5, 2025 15:33
Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>
This PR fixes a networking issue where the Redis service was not attached to the shared `mosip_network`, preventing Mimoto from connecting to Redis.

Redis is required for token caching and issuance-related session management. Because Redis was missing from the shared network, Mimoto could not resolve the hostname `redis`, resulting in connection errors.

The fix adds the Redis container to the shared network:

redis:
  image: redis:alpine
  ports:
    - "6379:6379"
  volumes:
    - redis-data:/data
  networks:
    - network

With this change, Mimoto is now able to connect to Redis successfully, and the credential issuance flow operates correctly.


Signed-off-by: DrinkMoreJuice <118993821+DrinkMoreJuice@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Walkthrough

A networks configuration was added to the Redis service in docker-compose.yaml, connecting it to an external network named "network" for inter-service communication within the Injistack deployment environment.

Changes

Cohort / File(s) Summary
Docker Compose Network Configuration
docker-compose/docker-compose-injistack/docker-compose.yaml
Added networks property to Redis service, connecting it to external network named "network"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-file configuration change with straightforward network attachment
  • No logic modifications or functional impact
  • Standard Docker Compose networking syntax

Suggested reviewers

  • jackjain
  • vishwa-vyom

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update docker-compose.yaml' is vague and generic, using non-descriptive terms that don't convey the specific networking fix being implemented. Use a more specific title that describes the actual change, such as 'Add Redis service to shared network in docker-compose.yaml' or 'Fix Redis connectivity in docker-compose by adding network configuration'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 618684d and a142c40.

📒 Files selected for processing (1)
  • docker-compose/docker-compose-injistack/docker-compose.yaml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Piyush7034
Repo: mosip/inji-certify PR: 488
File: docker-compose/docker-compose-injistack/docker-compose.yaml:82-83
Timestamp: 2025-11-03T05:40:24.121Z
Learning: In the mosip/inji-certify repository, hardcoded database credentials in docker-compose files are acceptable when the database runs as a container in the same docker-compose stack for local development/testing purposes.
🔇 Additional comments (1)
docker-compose/docker-compose-injistack/docker-compose.yaml (1)

23-24: Fix is correct: Redis is now discoverable within the shared network.

This change resolves the networking issue by attaching the Redis service to the mosip_network shared network. This allows the Mimoto service (line 80) to resolve the hostname redis and establish connections for token caching and session management. The configuration is consistent with all other services in the compose file (database, certify, certify-nginx, mimoto-service, inji-web), all of which already reference the same network.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@swatigoel
Copy link
Contributor

@DrinkMoreJuice can you please raise PR for develop branch?

@DrinkMoreJuice DrinkMoreJuice changed the base branch from master to develop December 23, 2025 14:18
@DrinkMoreJuice
Copy link
Author

@DrinkMoreJuice can you please raise PR for develop branch?

I’ve updated this pull request to target the develop branch.

@swatigoel
Copy link
Contributor

@DrinkMoreJuice There are so many changes and conflicts in this PR. Looks like you need to raise fresh PR with only docker-compose changes.

@swatigoel
Copy link
Contributor

@DrinkMoreJuice can you please raise fresh PR for develop branch with changes specific to docker-compose only.

@preetighongal preetighongal added this to the 0.15.0 milestone Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants