Conversation
Signed-off-by: sanehema9 <[email protected]>
WalkthroughSeven locale files updated to change the ResetPasscodePage Changes
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Fix all issues with AI agents
In `@inji-web/src/locales/ar.json`:
- Line 111: The Arabic title string under the "title" key uses "كلمة المرور"
(password) while other passcode-related keys (setPasscode, enterPasscodeLabel,
setNewPasscode) use "رمز المرور"; update the "title" value to use "رمز المرور"
(e.g., "هل تريد إعادة تعيين رمز المرور الخاص بك؟") so terminology matches the
existing passcode vocabulary across the locale file.
In `@inji-web/src/locales/fr.json`:
- Line 111: The JSON key "title" currently uses "Réinitialiser votre mot de
passe ?" which is inconsistent with the rest of the passcode terminology; update
the "title" value to "Réinitialiser votre code d'accès ?" so it matches other
keys like setPasscode, enterPasscodeLabel, and setNewPasscode and preserves
parity with the English "Reset Your Passcode?" string.
In `@inji-web/src/locales/hi.json`:
- Line 111: The title string uses "पासवर्ड" which is inconsistent with other
keys like setPasscode, enterPasscodeLabel, and setNewPasscode that use "पासकोड";
update the "title" value to "अपना पासकोड रीसेट करें?" so terminology matches the
rest of the Hindi locale entries (e.g., setPasscode, enterPasscodeLabel,
setNewPasscode).
In `@inji-web/src/locales/kn.json`:
- Line 111: The "title" string in kn.json uses "ಪಾಸ್ವರ್ಡ್" while the PR aims to
standardize on "passcode" and other keys on the same page (e.g.,
resetInstruction.question, setNewPasscode) use "ಪಾಸ್ಕೋಡ್"; update the value for
the "title" key to use "ಪಾಸ್ಕೋಡ್" (change "ನಿಮ್ಮ ಪಾಸ್ವರ್ಡ್ ಅನ್ನು
ಮರುಹೊಂದಿಸುವುದೇ?" to "ನಿಮ್ಮ ಪಾಸ್ಕೋಡ್ ಅನ್ನು ಮರುಹೊಂದಿಸುವುದೇ?") so terminology is
consistent across the locale file.
In `@inji-web/src/locales/pt.json`:
- Line 111: The title string uses "senha" while other passcode-related keys use
"código de acesso", causing inconsistent terminology; update the "title" value
to use the same term (e.g., "Redefinir seu código de acesso?") so it matches
keys like setPasscode, enterPasscodeLabel, and setNewPasscode and maintains
parity with the English "Reset Your Passcode?".
In `@inji-web/src/locales/ta.json`:
- Line 111: The title string "title" uses கடவுச்சொல்லை (password) but the page
uses கடவுக்குறியீடு (passcode) elsewhere; update the "title" value to use the
passcode term for consistency (e.g., change to "உங்கள் கடவுக்குறியீட்டை
மீட்டமைக்க வேண்டுமா?") and scan the related keys resetInstruction.question and
setNewPasscode to ensure all user-facing strings on this page consistently use
"கடவுக்குறியீடு".
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
inji-web/src/locales/ar.jsoninji-web/src/locales/en.jsoninji-web/src/locales/fr.jsoninji-web/src/locales/hi.jsoninji-web/src/locales/kn.jsoninji-web/src/locales/pt.jsoninji-web/src/locales/ta.json
🔇 Additional comments (1)
inji-web/src/locales/en.json (1)
111-111: LGTM!The title change from "Forgot Your Passcode?" to "Reset Your Passcode?" aligns with the PR objective and maintains consistent "Passcode" terminology throughout the file.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Signed-off-by: sanehema9 <[email protected]>
|
now i changed the files |
Signed-off-by: sanehema9 <[email protected]>
|
@sanchi-singh24 @sanehema9 The bug description/expected behavior mentioned in the story and fix video is not matching. Was the expectation changed during the development ? |
Description
Changed "forgot passcode " to "Reset passcode" in language translation files for consistent terminology across the application.
Changes
Updated translation keys in JSON language files
Changed all instances of "forgot passcode" to "Reset passcode"
Issue ticket number and link
INJIWEB-1584[https://mosip.atlassian.net/browse/INJIWEB-1584]
Video
INJIWEB-1584.mp4
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.