Skip to content

Comments

INJIWEB-1584#488

Open
sanehema9 wants to merge 3 commits intoinji:developfrom
sanehema9:INJIWEB-1584
Open

INJIWEB-1584#488
sanehema9 wants to merge 3 commits intoinji:developfrom
sanehema9:INJIWEB-1584

Conversation

@sanehema9
Copy link

@sanehema9 sanehema9 commented Jan 15, 2026

Description

Changed "forgot passcode " to "Reset passcode" in language translation files for consistent terminology across the application.

Changes

Updated translation keys in JSON language files
Changed all instances of "forgot passcode" to "Reset passcode"

Issue ticket number and link

INJIWEB-1584[https://mosip.atlassian.net/browse/INJIWEB-1584]

Video

INJIWEB-1584.mp4

Summary by CodeRabbit

  • Localization
    • Updated the Reset Passcode page title wording across supported languages — changed phrasing from "Forgot your passcode?" to "Reset your passcode?" for clearer guidance to users.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: sanehema9 <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Walkthrough

Seven locale files updated to change the ResetPasscodePage title string from a "Forgot your passcode?" phrasing to a "Reset your passcode/password?" phrasing across Arabic, English, French, Hindi, Kannada, Portuguese, and Tamil.

Changes

Cohort / File(s) Summary
Locale String Updates
inji-web/src/locales/ar.json, inji-web/src/locales/en.json, inji-web/src/locales/fr.json, inji-web/src/locales/hi.json, inji-web/src/locales/kn.json, inji-web/src/locales/pt.json, inji-web/src/locales/ta.json
Updated ResetPasscodePage.title values: replaced "Forgot your passcode?" phrasing with "Reset your passcode/password?" phrasing in each locale file (single-line string change per file).

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through seven lines with a cheerful twitch,
Swapping "forgot" for "reset" — a tiny stitch.
Multilingual crumbs I gathered on my way,
A hop, a nibble, and the UI's bright today.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'INJIWEB-1584' is only a ticket reference and does not describe the actual changes made in the pull request. Use a descriptive title that summarizes the main change, such as 'Update reset passcode terminology in locale files' or 'Change passcode forgot to reset across translations'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 162c2d3 and 914faae.

📒 Files selected for processing (2)
  • inji-web/src/locales/pt.json
  • inji-web/src/locales/ta.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • inji-web/src/locales/ta.json
🔇 Additional comments (1)
inji-web/src/locales/pt.json (1)

111-111: LGTM! Terminology is now consistent.

The updated title "Redefinir seu código de acesso?" correctly uses "código de acesso" (passcode) which aligns with other passcode-related strings in this file (e.g., setPasscode, enterPasscodeLabel, setNewPasscode). This addresses the previous review feedback and matches the PR objective of changing from "forgot" to "reset" terminology.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

🤖 Fix all issues with AI agents
In `@inji-web/src/locales/ar.json`:
- Line 111: The Arabic title string under the "title" key uses "كلمة المرور"
(password) while other passcode-related keys (setPasscode, enterPasscodeLabel,
setNewPasscode) use "رمز المرور"; update the "title" value to use "رمز المرور"
(e.g., "هل تريد إعادة تعيين رمز المرور الخاص بك؟") so terminology matches the
existing passcode vocabulary across the locale file.

In `@inji-web/src/locales/fr.json`:
- Line 111: The JSON key "title" currently uses "Réinitialiser votre mot de
passe ?" which is inconsistent with the rest of the passcode terminology; update
the "title" value to "Réinitialiser votre code d'accès ?" so it matches other
keys like setPasscode, enterPasscodeLabel, and setNewPasscode and preserves
parity with the English "Reset Your Passcode?" string.

In `@inji-web/src/locales/hi.json`:
- Line 111: The title string uses "पासवर्ड" which is inconsistent with other
keys like setPasscode, enterPasscodeLabel, and setNewPasscode that use "पासकोड";
update the "title" value to "अपना पासकोड रीसेट करें?" so terminology matches the
rest of the Hindi locale entries (e.g., setPasscode, enterPasscodeLabel,
setNewPasscode).

In `@inji-web/src/locales/kn.json`:
- Line 111: The "title" string in kn.json uses "ಪಾಸ್‌ವರ್ಡ್" while the PR aims to
standardize on "passcode" and other keys on the same page (e.g.,
resetInstruction.question, setNewPasscode) use "ಪಾಸ್‌ಕೋಡ್"; update the value for
the "title" key to use "ಪಾಸ್‌ಕೋಡ್" (change "ನಿಮ್ಮ ಪಾಸ್‌ವರ್ಡ್ ಅನ್ನು
ಮರುಹೊಂದಿಸುವುದೇ?" to "ನಿಮ್ಮ ಪಾಸ್‌ಕೋಡ್ ಅನ್ನು ಮರುಹೊಂದಿಸುವುದೇ?") so terminology is
consistent across the locale file.

In `@inji-web/src/locales/pt.json`:
- Line 111: The title string uses "senha" while other passcode-related keys use
"código de acesso", causing inconsistent terminology; update the "title" value
to use the same term (e.g., "Redefinir seu código de acesso?") so it matches
keys like setPasscode, enterPasscodeLabel, and setNewPasscode and maintains
parity with the English "Reset Your Passcode?".

In `@inji-web/src/locales/ta.json`:
- Line 111: The title string "title" uses கடவுச்சொல்லை (password) but the page
uses கடவுக்குறியீடு (passcode) elsewhere; update the "title" value to use the
passcode term for consistency (e.g., change to "உங்கள் கடவுக்குறியீட்டை
மீட்டமைக்க வேண்டுமா?") and scan the related keys resetInstruction.question and
setNewPasscode to ensure all user-facing strings on this page consistently use
"கடவுக்குறியீடு".
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32edfb7 and b504d91.

📒 Files selected for processing (7)
  • inji-web/src/locales/ar.json
  • inji-web/src/locales/en.json
  • inji-web/src/locales/fr.json
  • inji-web/src/locales/hi.json
  • inji-web/src/locales/kn.json
  • inji-web/src/locales/pt.json
  • inji-web/src/locales/ta.json
🔇 Additional comments (1)
inji-web/src/locales/en.json (1)

111-111: LGTM!

The title change from "Forgot Your Passcode?" to "Reset Your Passcode?" aligns with the PR objective and maintains consistent "Passcode" terminology throughout the file.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Signed-off-by: sanehema9 <[email protected]>
@sanehema9
Copy link
Author

now i changed the files

Signed-off-by: sanehema9 <[email protected]>
@jackjain
Copy link
Contributor

@sanchi-singh24 @sanehema9 The bug description/expected behavior mentioned in the story and fix video is not matching. Was the expectation changed during the development ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants