Critical code review PR - Last sprint handover checklist of 0.15.0 release#544
Critical code review PR - Last sprint handover checklist of 0.15.0 release#544Prafulrakhade merged 0 commit intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| log.error("Wallet binding error occured for tranaction id " + requestDTO.getRequest().getIndividualId(), e); | ||
| String[] errorObj = Utilities.handleExceptionWithErrorCode(e); | ||
| List<ErrorDTO> errors = Utilities.getErrors(errorObj[0], errorObj[1]); | ||
| responseWrapper.setResponse(null); |
Check failure
Code scanning / CodeQL
Server-side request forgery
vishwa-vyom
left a comment
vishwa-vyom
left a comment
There was a problem hiding this comment.
Reviewed file changes and added comments excluding the test and api-test files.
docker-compose/docker-compose.yml
Outdated
| - ./config/credential-template.html:/config/server/credential-template.html | ||
| - ./nginx.conf:/etc/nginx/nginx.conf | ||
| mimoto-service: | ||
| container_name: 'Mimoto-Service' | ||
| image: 'mosipid/mimoto:0.12.0' | ||
| image: 'mosipid/mimoto:0.14.0' |
There was a problem hiding this comment.
is this not suppose to be mosipdev with release-0.15.0 tag ?
There was a problem hiding this comment.
I see this is not yet changed, not sure if QA verified with correct version
There was a problem hiding this comment.
@vishwa-vyom QA tested using inji-web not mimoto docker-compose.
https://github.com/mosip/inji-web/blob/release-0.11.x/docker-compose/docker-compose.yml
There was a problem hiding this comment.
Got it, but QA needs to test this docker compose also right ?
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This level of validation is required ? Do we have a story/task on this ?
There was a problem hiding this comment.
We need to support two formats ldp and mso_mDoc where responses are different. https://mosip.atlassian.net/browse/INJIMOB-1862
There was a problem hiding this comment.
Is this part of release scope ?
There was a problem hiding this comment.
yes @vishwa-vyom
it's part of release and mobile QAs have tested mDL VCs
There was a problem hiding this comment.
There was a problem hiding this comment.
As discussed this is getting captured directly in the release notes
4 participants
This PR is created just to add the review comments as part of the critical code review task of last sprint handover checklist for release of 0.15.0 version.
** THIS PR SHOULD NOT BE MERGED **