Critical code review PR - Last sprint handover checklist of 0.17.0 release#615
Closed
vishwa-vyom wants to merge 173 commits intorelease-0.16.xfrom
Closed
Critical code review PR - Last sprint handover checklist of 0.17.0 release#615vishwa-vyom wants to merge 173 commits intorelease-0.16.xfrom
vishwa-vyom wants to merge 173 commits intorelease-0.16.xfrom
Conversation
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
Signed-off-by: Mohanachandran S <165888272+mohanachandran-s@users.noreply.github.com>
MOSIP-37476 - updated the docker file for jdk version
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
* [INJIMOB-2262]: fix automation error code mismatch Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIMOB-2262]: fix automation error code mismatch Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIMOB-2262]: fix automation error code mismatch Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIMOB-2262]: fix automation error code mismatch Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> --------- Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com>
[DSD-6676] Update nexus-staging-maven-plugin version
Signed-off-by: Vijay Kumar S <94220135+vijay151096@users.noreply.github.com>
Signed-off-by: Mohanachandran S <165888272+mohanachandran-s@users.noreply.github.com>
Signed-off-by: Mohanachandran S <165888272+mohanachandran-s@users.noreply.github.com>
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
MOSIP-37888 | Make the OIDC client key name configurable to fetch from actuator for mimoto API test rig
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
MOSIP-37888 |
MOSIP-37793 - Updated the Readme file
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
MOSIP-37942 | Updated delete query file name
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
* [INJIWEB-1202] Remove id from the json if id is null Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1202] Fix for wrong characters getting embedded in the VC Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1202] Fix rest api client to have custom headers method Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> --------- Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
…OST (#532) Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
* MOSIP-36455 - Merge release 0.14.x branch with develop Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in> * MOSIP-36455 - Merge release 0.14.x branch with develop Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in> * INJIWEB-967 - Updated Automation Tests for Sunbird and eSignet Issues Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in> * MOSIP-38392 - updated the apitest commons version Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in> * MOSIP-38392 - Updated the issuer name for sunbird Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in> --------- Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
Signed-off-by: techno-467 <prafulrakhade02@gmail.com>
* [INJIMOB-2452]: Add credential_issuer_identifier to IssuerDTO Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-2452]: Update Credential Issuer Identifier to Credential Issuer Host Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-2452]: Add issuer host field in local mimoto-issuers-config.json Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-2452]: Move enabled field as last attribute Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-2452]: Attribute name change for issuer_id Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-2452]: Update issuerId variable name Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-2452]: Update in TestUtilities. Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> --------- Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com>
* [INJIMOB-2452]: Add Credential Issuer Host Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-2452]: Update in Test Utilities Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-2452]: Update credential_issuer_host in Test Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> --------- Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…tor-issuer [INJIWEB-1436] add constuctor annotations on dataShareResponseDto
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…lt properties Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Injiweb 1436 update caffiene cache property names
Signed-off-by: Kamlesh <kamlesh.bisht@infosys.com>
[INJIWEB-1405]: Fixed Api Documentation
…se file Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
* MOSIP-40714 - Pushed the code to release 0.17x branch Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in> * Updated the POM version Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in> --------- Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
[DSD-7621] update the docker compose file to use mosipqa images
…lidation as soon as an error is found for any issuer (#647) * [INJIMOB-3140] in issuersValiationConfig file throw the exception immediately if any validations fail for an issuer rather than proceeding further to check for other issuers Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-3140] update the validation logic in issuersValidationConfig file to accumulate all the issuers errors and then throw the error in the end Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-3140] add missing annotations in the issuerDTO file and write test cases for issuerValidationConfig file Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> --------- Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
…tup (#653) * Updating read me to correctly setup token_endpoint for inji mobile setup Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * Updating read me to correctly setup token_endpoint for inji mobile setup Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> --------- Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
[INJIWEB-1436] Updating docs and adding description for issuer config endpoint fields
Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
…t mimoto image updated the docker compose file to use correct mimoto image
* Adding release 17 documentation Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * corrected the file in which cache properties are present Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> --------- Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
* Corrected issuer config endpoint response sample Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * Corrected issuer config endpoint wellknown endpoint values Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> --------- Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>
Signed-off-by: techno-467 <prafulrakhade02@gmail.com>
[DSD-7808] injiweb 0.12.0 release
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
[DSD-7823] injiweb 0.12.0 post release changes
…ger.yml Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
[DSD-7833] removed mimoto-apitest publish-to-nexus job from push-trig…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created just to add the review comments as part of the critical code review task of last sprint handover checklist for release of 0.17.0 version.
** THIS PR SHOULD NOT BE MERGED **