Skip to content

[INJIMOB-3711] - Update configuration to publish artifact to io.inji group#110

Merged
swatigoel merged 1 commit intoinji:developfrom
tw-mosip:develop
Jan 22, 2026
Merged

[INJIMOB-3711] - Update configuration to publish artifact to io.inji group#110
swatigoel merged 1 commit intoinji:developfrom
tw-mosip:develop

Conversation

@swatigoel
Copy link
Contributor

@swatigoel swatigoel commented Jan 22, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Enhanced artifact publishing infrastructure with new metadata fields for project identification and source control management.
    • Simplified continuous integration pipeline by removing redundant keystore-related build jobs from automated workflows.
    • Updated project configuration with refreshed organization and developer information.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Walkthrough

The pull request updates CI/CD pipelines and artifact publishing configuration. It removes secure keystore-related build and publish jobs from the push trigger workflow, adds a configurable group_path input to the artifact build workflow with updated secret references, and refactors the Gradle publishing script to support organization transitions from io.mosip to io.inji.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/android-artifact-build.yml, .github/workflows/push-trigger.yml
Added configurable group_path input (choices: io/inji, io/mosip) to android-artifact-build workflow and updated secret from OSSRH_CENTRAL_URL to GRADLE_OSSRH_URL. Removed build-secure-keystore and publish-secure-keystore-to-npm-registry jobs from push-trigger workflow.
Gradle Build Configuration
kotlin/android/publish-artifact.gradle
Refactored POM dependencies block construction, added metadata fields (name, url, description, scm), updated developer organization from io.mosip to io.inji, and changed publication groupId accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hop hop, the pipelines now flow with grace,
io.inji takes its rightful place,
Secure keystores removed from the fray,
Config refactored in every way!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating configuration to publish artifacts to the io.inji group, which is demonstrated across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In @.github/workflows/android-artifact-build.yml:
- Around line 24-31: The workflow's GROUP_PATH choice isn't used by the Gradle
publish script: update kotlin/android/publish-artifact.gradle to read the
groupId dynamically (e.g., from an environment variable or project property)
instead of the hardcoded "io.inji" so the artifact's groupId matches the
selected GROUP_PATH, or remove the io/mosip option from the workflow if that
group isn't supported; specifically, make the script consume an env/project
property (referencing the GROUP_PATH input) and set the Gradle property/groupId
accordingly (replace the hardcoded groupId reference).

In `@kotlin/android/publish-artifact.gradle`:
- Around line 23-25: The POM metadata uses the wrong URL (copy-pasted pixelpass)
in the asNode().appendNode('url', ...) call next to asNode().appendNode('name',
"Secure-Keystore"); update the URL value to the Secure-Keystore project's actual
repository/homepage URL (replace "https://github.com/inji/pixelpass" with the
correct Secure-Keystore URL) so the POM description and url match the
asNode().appendNode('name', "Secure-Keystore") and
asNode().appendNode('description', ...) entries.
🧹 Nitpick comments (2)
kotlin/android/publish-artifact.gradle (2)

39-45: Placeholder developer ID should be replaced.

The developer id is still set to the placeholder value 'Your developer ID'. Consider replacing it with an actual identifier for better POM metadata quality.

♻️ Suggested fix
          asNode().appendNode('developers').appendNode('developer').with {
-            appendNode('id', 'Your developer ID')
-            appendNode('name', 'Mosip')
+            appendNode('id', 'inji')
+            appendNode('name', 'Inji')
            appendNode('email', '[email protected]')
            appendNode('organization', 'io.inji')
            appendNode('organizationUrl', 'https://inji.io')
          }

47-53: Consider filtering out null dependency attributes.

If any dependency in the implementation configuration has a null group, name, or version (e.g., project dependencies or BOMs), this will produce invalid POM entries. Consider adding a null check.

♻️ Suggested defensive filtering
          def dependenciesNode = asNode().appendNode('dependencies')
-          project.configurations.implementation.allDependencies.each {
+          project.configurations.implementation.allDependencies.findAll { it.group && it.name && it.version }.each {
            def dependencyNode = dependenciesNode.appendNode('dependency')
            dependencyNode.appendNode('groupId', it.group)
            dependencyNode.appendNode('artifactId', it.name)
            dependencyNode.appendNode('version', it.version)
          }

@swatigoel swatigoel merged commit 91ca873 into inji:develop Jan 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants