[INJIMOB-3711] - Update configuration to publish artifact to io.inji group#110
[INJIMOB-3711] - Update configuration to publish artifact to io.inji group#110swatigoel merged 1 commit intoinji:developfrom
Conversation
…group Signed-off-by: Swati Goel <[email protected]>
WalkthroughThe pull request updates CI/CD pipelines and artifact publishing configuration. It removes secure keystore-related build and publish jobs from the push trigger workflow, adds a configurable group_path input to the artifact build workflow with updated secret references, and refactors the Gradle publishing script to support organization transitions from io.mosip to io.inji. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/android-artifact-build.yml:
- Around line 24-31: The workflow's GROUP_PATH choice isn't used by the Gradle
publish script: update kotlin/android/publish-artifact.gradle to read the
groupId dynamically (e.g., from an environment variable or project property)
instead of the hardcoded "io.inji" so the artifact's groupId matches the
selected GROUP_PATH, or remove the io/mosip option from the workflow if that
group isn't supported; specifically, make the script consume an env/project
property (referencing the GROUP_PATH input) and set the Gradle property/groupId
accordingly (replace the hardcoded groupId reference).
In `@kotlin/android/publish-artifact.gradle`:
- Around line 23-25: The POM metadata uses the wrong URL (copy-pasted pixelpass)
in the asNode().appendNode('url', ...) call next to asNode().appendNode('name',
"Secure-Keystore"); update the URL value to the Secure-Keystore project's actual
repository/homepage URL (replace "https://github.com/inji/pixelpass" with the
correct Secure-Keystore URL) so the POM description and url match the
asNode().appendNode('name', "Secure-Keystore") and
asNode().appendNode('description', ...) entries.
🧹 Nitpick comments (2)
kotlin/android/publish-artifact.gradle (2)
39-45: Placeholder developer ID should be replaced.The developer
idis still set to the placeholder value'Your developer ID'. Consider replacing it with an actual identifier for better POM metadata quality.♻️ Suggested fix
asNode().appendNode('developers').appendNode('developer').with { - appendNode('id', 'Your developer ID') - appendNode('name', 'Mosip') + appendNode('id', 'inji') + appendNode('name', 'Inji') appendNode('email', '[email protected]') appendNode('organization', 'io.inji') appendNode('organizationUrl', 'https://inji.io') }
47-53: Consider filtering out null dependency attributes.If any dependency in the
implementationconfiguration has a nullgroup,name, orversion(e.g., project dependencies or BOMs), this will produce invalid POM entries. Consider adding a null check.♻️ Suggested defensive filtering
def dependenciesNode = asNode().appendNode('dependencies') - project.configurations.implementation.allDependencies.each { + project.configurations.implementation.allDependencies.findAll { it.group && it.name && it.version }.each { def dependencyNode = dependenciesNode.appendNode('dependency') dependencyNode.appendNode('groupId', it.group) dependencyNode.appendNode('artifactId', it.name) dependencyNode.appendNode('version', it.version) }
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.