[DRAFT PR] Critical code review PR - Last sprint handover checklist of 1.3.0 release#108
Closed
[DRAFT PR] Critical code review PR - Last sprint handover checklist of 1.3.0 release#108
Conversation
Signed-off-by: Alka Prasad <[email protected]>
* [INJIMOB-1699] add es256k supprt Signed-off-by: Abhishek Paul <[email protected]> * [INJIMOB-1699] refactor code Signed-off-by: Abhishek Paul <[email protected]> --------- Signed-off-by: Abhishek Paul <[email protected]>
* [INJIMOB-3102] update did web url parsing logic Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]: Did url Parsing based on path components Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]: Did url Parsing based on path components Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]: Did url Parsing based on path components Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]:Upadted Did URl parsing Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]:did url parsing correction Signed-off-by: Sairam Girirao <[email protected]> --------- Signed-off-by: sairam-girirao_infosys <[email protected]> Signed-off-by: Sairam Girirao <[email protected]>
Signed-off-by: Abhishek Paul <[email protected]>
…url (#98) Signed-off-by: Alka Prasad <[email protected]>
* [INJIVER-943] - Add VP proof verification api Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - update readme Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - refactor the code and add support for proofvalue Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - typo fix in readme Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - add explicit check for proof type when getting jws/proofvalue Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - add supported did types in readme Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - handle unsupported vp token type gracefully Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - handle unsupported vp token type gracefully with json check Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - fix key type for ed25119 Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - move vc verification part of vp token verification Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - update readme Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - update vp verification status to follow same type as vc verification status Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - catch JSON-LD processing exception specifically and hrow custom exception Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - update status of VP verification to VALID instead of success Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - update readme and comment for vc string sending justification Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - update readme Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - use internal decoder for base64 decode Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-943] - rename decoder class Signed-off-by: Sreenadh S <[email protected]> --------- Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
…vc verification status Signed-off-by: Sreenadh S <[email protected]>
…row custom exception Signed-off-by: Sreenadh S <[email protected]>
…success Signed-off-by: Sreenadh S <[email protected]>
…fication Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
…-support [INJIVER-991] JsonWebSignature2020 support
Signed-off-by: Sreenadh S <[email protected]>
swatigoel
commented
Jun 16, 2025
vc-verifier/kotlin/vcverifier/src/main/java/io/mosip/vercred/vcverifier/PresentationVerifier.kt
Show resolved
Hide resolved
* [INJIVER-1155] - update readme typo Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-1155] - update readme with supported did methoeds from earlier Signed-off-by: Sreenadh S <[email protected]> * [INJIVER-1155] - update archiveVersion to 1.3.0-SNAPSHOT Signed-off-by: Sreenadh S <[email protected]> --------- Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: rajapandi1234 <[email protected]>
Contributor
Author
|
Closing this as review is done and changes are ready for release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.