Critical code review PR - Last sprint handover checklist of 1.3.0 release#96
Closed
vishwa-vyom wants to merge 5 commits intomasterfrom
Closed
Critical code review PR - Last sprint handover checklist of 1.3.0 release#96vishwa-vyom wants to merge 5 commits intomasterfrom
vishwa-vyom wants to merge 5 commits intomasterfrom
Conversation
Signed-off-by: Alka Prasad <[email protected]>
* [INJIMOB-1699] add es256k supprt Signed-off-by: Abhishek Paul <[email protected]> * [INJIMOB-1699] refactor code Signed-off-by: Abhishek Paul <[email protected]> --------- Signed-off-by: Abhishek Paul <[email protected]>
* [INJIMOB-3102] update did web url parsing logic Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]: Did url Parsing based on path components Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]: Did url Parsing based on path components Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]: Did url Parsing based on path components Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]:Upadted Did URl parsing Signed-off-by: sairam-girirao_infosys <[email protected]> * [INJIMOB-3102]:did url parsing correction Signed-off-by: Sairam Girirao <[email protected]> --------- Signed-off-by: sairam-girirao_infosys <[email protected]> Signed-off-by: Sairam Girirao <[email protected]>
Signed-off-by: Abhishek Paul <[email protected]>
vishwa-vyom
commented
May 20, 2025
| val verificationMethods = didDocument[VERIFICATION_METHOD] as? List<Map<String, Any>> | ||
| ?: throw PublicKeyNotFoundException("Verification method not found in DID document") | ||
|
|
||
| val verificationMethod = verificationMethods.firstOrNull() |
Contributor
Author
There was a problem hiding this comment.
Critical: I think we should not take the first, rather we should filter with the id field matching the verificationMethod URI
| * - 0x02 (Integer marker) + Length of S + S value | ||
| * | ||
| */ | ||
| private fun convertRawSignatureToDER(signature: ByteArray): ByteArray { |
Contributor
Author
There was a problem hiding this comment.
Can we not use bouncycastle methods to do this conversion instead of us handling ?
…url (#98) Signed-off-by: Alka Prasad <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created just to add the review comments as part of the critical code review task of last sprint handover checklist for release of 1.3.0 version.
** THIS PR SHOULD NOT BE MERGED **