Fix/session store cleanup interval#1
Open
jee7s wants to merge 10 commits into
Open
Conversation
connect-session-knex defaults to running a DELETE on expired sessions every 60 seconds. Set clearInterval to 3600000ms to reduce DB churn. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Expose DB connection pool minimum and session store cleanup interval as configurable options under the db: config block. Defaults are min=2 and sessionCleanupInterval=86400000 (1 day). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keeps the data.yml default at the original connect-session-knex value. Users can override to a longer interval (e.g. 86400000) in config.yml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…container config Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Caches the DB health check result and re-queries at most once per interval (default 4 hours) to avoid keeping the connection alive. Configurable via db.healthCheckInterval in config.yml or DB_HEALTH_CHECK_INTERVAL env var in containers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Move /healthz before Passport middleware so healthchecks don't trigger deserializeUser - Cache deserialized users in memory (default 4h, configurable via auth.userCacheTTL / AUTH_USER_CACHE_TTL) - Increase analytics cache TTL default to 1 day (configurable via analytics.cacheTTL / ANALYTICS_CACHE_TTL) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…are dependency Moving all of ctrl.common early caused req.i18n to be undefined for page routes since localization middleware hadn't run yet. Now only /healthz is registered early; ctrl.common remains in its original position. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nup default - The 4h deserializeUser cache had no invalidation path: flush it in reloadGroups (covers group/permission edits incl. the cross-instance event) and drop the entry on user update/delete/deactivate — permission revocations apply immediately again. - /healthz is the ALB + ECS health check: only cache success for the full healthCheckInterval; a failed probe re-checks after 60s instead of pinning 503 for 4h and cycling healthy tasks. - Ship the documented sessionCleanupInterval default (86400000): the 60000 default ran a DELETE every minute, which keeps Aurora from ever idling — the exact cost this PR exists to eliminate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.