-
Notifications
You must be signed in to change notification settings - Fork 63
Blockfrost #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockfrost #1396
Conversation
6ad889b
to
3a98aef
Compare
|
8ca8ce2
to
9008290
Compare
fb2b479
to
bd4bad3
Compare
48eaa57
to
36fe0b8
Compare
8ad601d
to
7ce4bc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only clear thing is I have not clear which is the target here 😄 .
Please @ginnun ignore my review comments; let's clarify which is the target in some of our DS, next I can review my review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Anyway it's almost impossible to spot every possible issues in some calls.
If not already done, please log a ticket to create an e2e test against deployed environments to compare the results from BlockfrostProvider
s and DbSyncProvider
s.
The test should include a well known set of objects (transactions for the ChainHistoryProvider
, tokens for the AssetProvider
and so on...) which makes us sure all the possible cases are covered.
Ex. a CIP-25 token, a CIP-68 token, a token without assetName
, and so on.
This reverts commit e26037f
…ient as is and update codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
Context
This PR aims to add Blockfrost providers to the codebase by reverting a 2-year-old commit.
File content modifications can easily be reviewed in this commit.
Proposed Solution
blockfrost
toblockfrost-client
and replicatecardano-services-client
folder structureImportant Changes Introduced
"@blockfrost/blockfrost-js": "npm:[email protected]"
, now using using"@blockfrost/blockfrost-js": "^5.5.0"
since it supports rate limiting.