-
Notifications
You must be signed in to change notification settings - Fork 63
fix(wallet): dynamicChangeResolver gives preference to lower derivation indices #1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): dynamicChangeResolver gives preference to lower derivation indices #1469
Conversation
efc9572 to
143461f
Compare
|
…orted by derivation index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @AngelCastilloB 🦾
Context
User used Lace to manage his ada handle settings ( a lot of those ) and Eternl wouldn't show his balance anymore ( because of the discovery gap )
Then after quite a few transactions, it suddenly used a newly created (index 557) address for change and sticked to it for the following 3 transactions.
Lace is probably picking the newly created unused address as change address sometimes. This changes makes sure it always picks the same addresses per reward accounts and its always the lowest derivation index.