-
Notifications
You must be signed in to change notification settings - Fork 63
test(e2e): abort k6 wallets test if too many failed requests #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): abort k6 wallets test if too many failed requests #1479
Conversation
WHY: - show that test is failing, otherwise failed requests are considered successful with small response time - To save on K6 VUh
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Context
wallets K6 test does not fail regardless of how many requests fail.
P95, P99 response times seem to include the failed response times, which are usually fast.
Proposed Solution
abort k6 wallets test if too many failed requests
Important Changes Introduced