-
Couldn't load subscription status.
- Fork 63
fix(core): protocol parameters update now correctly deserializes extra entropy when it set as empty #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
95794f6 to
fed1cae
Compare
…a entropy when it set as empty
fed1cae to
bcf3d15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Context
We were incorrectly deserializing extra entropy in protocol params update when the entropy bytes were empty (which is a valid use case). Even tho this parameter is deprecated we should be able to deserialize transactions with this field properly as there are some on mainnet:
See:
https://cardanoscan.io/transaction/fc863a441b55acceebb7d25c81ff7259e4fc9b92fbdf6d594118fb8f1110a78c
Proposed Solution
Fix serialization/de-serialization logic