-
Notifications
You must be signed in to change notification settings - Fork 63
test(e2e): reduce test flakiness #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! 💪
tx confirmation check result may be dependent on which provider completes earlier
0646cee to
452bb95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you @iccicci
|
Context
Out e2e test often uses a piec of code like following
next perform the checks.
The problem is this code is based only on
ChainHistoryProviderwhile some checks are performed onObservables sometimes based on other providers (AssetProvider,UtxoProvider, etc...).This is a source of flakiness as check result may be dependent on which provider completes earlier.
Proposed Solution
Substitute given piece of code (where required) with
submitAndConfirmutility, which internally also waits for the wallet to be settled, i.e. all the providers finished their tasks.This also slightly reduce code repetition.