Skip to content

Conversation

@bernokl
Copy link
Contributor

@bernokl bernokl commented Oct 21, 2024

Context

Enable asset-provider on dev-mainnewt. Disable asset on monolith

Copy link
Collaborator

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@gytis-ivaskevicius gytis-ivaskevicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either keep asset provider on monolithic backend or enable provider everywhere

Leaving it enabled is fine, it's not going to get hit anyway

@iccicci
Copy link
Collaborator

iccicci commented Oct 21, 2024

Please either keep asset provider on monolithic backend or enable provider everywhere

Leaving it enabled is fine, it's not going to get hit anyway

Nice catch! Yes, please enable asset-provider everywhere.

@bernokl
Copy link
Contributor Author

bernokl commented Oct 29, 2024

@iccicci is this PR still relevant? or can I close it?

@bernokl bernokl closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants