-
Notifications
You must be signed in to change notification settings - Fork 63
fix(wallet): getCollateral callback now passes empty array to wallet if no colateral found #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): getCollateral callback now passes empty array to wallet if no colateral found #1533
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can an integration test be added here?
I think so, Will add a few tests, I will also rewrite the logic a bit, I realize that if there are no UTXOs, we should return NULL here, we should only pass empty array if there are no pure UTXOs |
bd1c4e6 to
459e760
Compare
…if no colateral found
459e760 to
833db68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @AngelCastilloB ! 🚀
Context
If not suitable UTXO for collateral is found, we still need to call the getColalteral callback provided by the wallet to give it an opportunity to create a new collateral UTXO