-
Notifications
You must be signed in to change notification settings - Fork 63
fix: reject PRs without @esbuild/linux-x64@npm in yarn-project.nix & fix the NixBuild.net integration
#1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f12abea to
b185f9e
Compare
b81902d to
4f2b40a
Compare
564f090 to
ef8f43b
Compare
…ction` ref. in `diff`
220e224 to
f71a350
Compare
|
@esbuild/linux-x64@npm in yarn-project.nix@esbuild/linux-x64@npm in yarn-project.nix & fix the NixBuild.net integration
Context
Bug 1
Our build breaks if the last
yarn installthat updates the lock file was done on a non-x86_64-linuxmachine.Unfortunately,
.yarn/plugins/yarn-plugin-nixify.cjsthen removes Linux-specific dependencies fromyarn-project.nix, adding ARM64 Darwin-specific ones, and a Nix build can no longer succeed on Linux.Bug 2
Additionally, some integration has broken between
std-actionand nixbuild.net, so now we trigger the build manually there. After that, it works.Proposed Solution
Bug 1
Reject PRs without
@esbuild/linux-x64@npminyarn-project.nix.Here you can see an example of a failed run based on a broken commit (b81902d): actions/runs/14400727809/job/40385721936.
And here is a correct run, rebased onto
master(4f2b40a): actions/runs/14400799480/job/40385942986Bug 2
Successful building & publishing:
docker://926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wycw9mc4hbwhxsc7jplqk749wn4a0k94.Successful diff:
@esbuild/linux-x64@npminyarn-project.nix& fix the NixBuild.net integration #1614 (comment) below.Important Changes Introduced
Umm, CI’s working again.