Skip to content

LW-12622 Remove useless dependency #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

LW-12622 Remove useless dependency #1625

merged 1 commit into from
May 26, 2025

Conversation

iccicci
Copy link
Collaborator

@iccicci iccicci commented May 26, 2025

Context

We have this dependency cycle issue.

lerna-lite WARN ECYCLE Dependency cycles detected, you should fix these!
lerna-lite WARN ECYCLE @cardano-sdk/cardano-services-client -> @cardano-sdk/util-dev -> @cardano-sdk/projection -> @cardano-sdk/ogmios -> @cardano-sdk/cardano-services-client
lerna-lite WARN ECYCLE @cardano-sdk/util-rxjs -> (nested cycle: @cardano-sdk/cardano-services-client -> @cardano-sdk/util-dev -> @cardano-sdk/projection -> @cardano-sdk/ogmios -> @cardano-sdk/cardano-services-client) -> @cardano-sdk/util-rxjs

Proposed Solution

Removed useless dependency from ogmios package.

@iccicci iccicci changed the title Remove useless dependency LW-12622 Remove useless dependency May 26, 2025
@rhyslbw rhyslbw merged commit f771ef6 into master May 26, 2025
7 of 8 checks passed
@rhyslbw rhyslbw deleted the chore/deps-fix branch May 26, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhyslbw rhyslbw rhyslbw approved these changes

@mkazlauskas mkazlauskas Awaiting requested review from mkazlauskas

@AngelCastilloB AngelCastilloB Awaiting requested review from AngelCastilloB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iccicci @rhyslbw