Skip to content

fix(crypto): remove setImmediate from async calls #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix(crypto): remove setImmediate from async calls #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/crypto/src/blake2b-hash.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ export const blake2b: Blake2b = {
return hash(outputLengthBytes).update(hexStringToBuffer(message)).digest('hex') as T;
},
async hashAsync<T extends HexBlob>(message: HexBlob, outputLengthBytes: number): Promise<T> {
return new Promise((resolve) => {
setImmediate(() => {
resolve(blake2b.hash<T>(message, outputLengthBytes));
});
});
return blake2b.hash<T>(message, outputLengthBytes);
}
};
6 changes: 1 addition & 5 deletions packages/crypto/src/strategies/CmlBip32Ed25519.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,7 @@ export class CmlBip32Ed25519 implements Bip32Ed25519 {
parentKey: Bip32PublicKeyHex,
derivationIndices: BIP32Path
): Promise<Bip32PublicKeyHex> {
return new Promise((resolve) => {
setImmediate(() => {
resolve(this.derivePublicKey(parentKey, derivationIndices));
});
});
return this.derivePublicKey(parentKey, derivationIndices);
}

public sign(
Expand Down
6 changes: 1 addition & 5 deletions packages/crypto/src/strategies/SodiumBip32Ed25519.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,7 @@ export class SodiumBip32Ed25519 implements Bip32Ed25519 {
parentKey: Bip32PublicKeyHex,
derivationIndices: BIP32Path
): Promise<Bip32PublicKeyHex> {
return new Promise((resolve) => {
setImmediate(() => {
resolve(this.derivePublicKey(parentKey, derivationIndices));
});
});
return this.derivePublicKey(parentKey, derivationIndices);
}

public sign(
Expand Down
Loading