chore: remove npm from dependencies #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonmaslowski
force-pushed
the
chore/remove-npm-from-dependencies
branch
from
d870b45 to
6eba226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
cryptoandtx-constructionpackages havenpmas dependencies, which seems incorrect. Moreover, it causes some problems in the lace-platform. Thenpmgets installed in thenode_modulesof the project and then when runningnpxfrom the terminal it resolves the npm from thenode_modulesinstead of the one installed globally. As a consequence npm v9 gets used instead of v10.Proposed Solution
Important Changes Introduced