refactor: relax CIP-8 signing threshold from 100 to 190 #1643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change increases the threshold for when payloads are hashed during CIP-8 signing from 100 to 190 bytes. This allows larger payloads to be signed directly without hashing, which can be useful for certain use cases where the full payload needs to be preserved.
AngelCastilloB
previously approved these changes
Aug 5, 2025
This updates the Docker base image to use Ubuntu 22.04 LTS instead of 20.04, providing newer system packages and extended support.
AngelCastilloB
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change increases the threshold for when payloads are hashed during CIP-8 signing from 100 to 190 bytes. This allows larger payloads to be signed directly without hashing, which can be useful for certain use cases where the full payload needs to be preserved.