feat(cat-voices): validating proposal submission action author #3814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llaborators_adjustments_3769_part2
….com:input-output-hk/catalyst-voices into feat/db_collaborators_adjustments_3769_part2
…llaborators_adjustments_3769_part2
…llaborators_adjustments_3769_part2
damian-molinski
added
the
a: proposal
…posal_submission_action_author
…g_proposal_submission_action_author_part2
Base automatically changed from
feat/validating_proposal_submission_action_author
to
feat/db_collaborators_adjustments_3769
December 4, 2025 15:37
…ating_proposal_submission_action_author_part2
…' of github.com:input-output-hk/catalyst-voices into feat/validating_proposal_submission_action_author_part2
damian-molinski
requested review from
LynxLynxx,
bstolinski and
dt-iohk
as code owners
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/voices/feat/validating_proposal_submission_action_author_part2 |
LynxLynxx
approved these changes
Dec 5, 2025
Contributor
LynxLynxx
left a comment
LynxLynxx
left a comment
There was a problem hiding this comment.
like extracting _getEffectiveProposalsCTE LGTM
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bstolinski
approved these changes
Dec 5, 2025
damian-molinski
merged commit b24ea9e
into
feat/db_collaborators_adjustments_3769
40 checks passed
damian-molinski
deleted the
feat/validating_proposal_submission_action_author_part2
branch
damian-molinski
added a commit
that referenced
this pull request
Dec 5, 2025
* chore: port over parameters changes * feat(cat-voices): adjust database to signed docs 0.0.4 (#3791) * tables * wip * proposals dao tests * bump db schema * db index name fix * migration -> use createAll() * update migration * update migration * chore: remove print * update ref dto flatten implementation * migration toFlatten() * fix: proposals dao * fix: documents dao and local drafts dao * chore: clean up TODO * fix: failing tests * chore: markdown order * web: skips for db tests * fix: db tests on web * fix: analyzer * unskip tests * rename * CatalystId.toUri -> CatalystId.toString * use same instead of identical * use hasLength * metadata dao tests * use hasLength in documents v2 dao * feat: use hasLength in proposals v2 dao tests * fix(cat-voices): storing catIds with coma usernames (#3813) * tables * wip * proposals dao tests * bump db schema * db index name fix * migration -> use createAll() * update migration * update migration * chore: remove print * update ref dto flatten implementation * migration toFlatten() * fix: proposals dao * fix: documents dao and local drafts dao * chore: clean up TODO * fix: failing tests * chore: markdown order * web: skips for db tests * fix: db tests on web * fix: analyzer * unskip tests * chore: use converters * update tests * hello world test * fix: documents dao hasLength * feat(cat-voices): filtering proposals by original author (#3810) * tables * wip * proposals dao tests * bump db schema * db index name fix * migration -> use createAll() * update migration * update migration * chore: remove print * update ref dto flatten implementation * migration toFlatten() * fix: proposals dao * fix: documents dao and local drafts dao * chore: clean up TODO * fix: failing tests * chore: markdown order * web: skips for db tests * fix: db tests on web * fix: analyzer * unskip tests * feat: filtering author on first version * change filter name from author to originalAuthor * Adds originalAuthor filter to documentsDao * authorId -> originalAuthorId * originalAuthors * fix: spelling * use authors from documents for originalAuthors * feat(cat-voices): validating proposal submission action author (#3814) * tables * wip * proposals dao tests * bump db schema * db index name fix * migration -> use createAll() * update migration * update migration * chore: remove print * update ref dto flatten implementation * migration toFlatten() * fix: proposals dao * fix: documents dao and local drafts dao * chore: clean up TODO * fix: failing tests * chore: markdown order * web: skips for db tests * fix: db tests on web * fix: analyzer * unskip tests * feat: filtering author on first version * change filter name from author to originalAuthor * Adds originalAuthor filter to documentsDao * authorId -> originalAuthorId * originalAuthors * fix: spelling * docs * use authors from documents for originalAuthors * fix: campaign total ask tests * fix: proposals dao tests * test: proposals dao authors * fix: spelling * chore: extract _getValidActionsCTE()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validating author of proposal submission action matches proposal original author
Related Issue(s)
Part of #3700
Description of Changes
Related Pull Requests
Please confirm the following checks