Skip to content

Update the reproducibility section of "Including Data in teal Applications" vignette's #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

llrs-roche
Copy link
Contributor

Pull Request

Fixes #1543

  • Updates the screenshots
  • I rewrote the section about reproducibility and verification. I expanded how teal_data objects work but I mention how the unverified object affects the (teal) application.

@llrs-roche llrs-roche added the core label Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Unit Tests Summary

  1 files   25 suites   2m 9s ⏱️
266 tests 210 ✅ 56 💤 0 ❌
451 runs  395 ✅ 56 💤 0 ❌

Results for commit c97b162.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💔 $103.69$ $+1.38$ $0$ $0$ $0$ $0$

Results for commit 7b9f9dc

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  67      11  83.58%   46, 48, 90-98
R/include_css_js.R                   11      11  0.00%    12-37
R/init.R                            146     100  31.51%   137-158, 188-196, 206-235, 238-239, 246-255, 258-267, 270-279, 283-293, 295
R/landing_popup_module.R             34      34  0.00%    22-57
R/module_bookmark_manager.R         153     122  20.26%   47-58, 78-133, 138-139, 151, 198, 233-310
R/module_data_summary.R             177      10  94.35%   25-26, 40, 50, 205, 236-240
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           229      56  75.55%   56-61, 72-81, 89-94, 107-111, 116-117, 290-313, 339, 366, 378, 385-386
R/module_init_data.R                 74       6  91.89%   38-43
R/module_nested_tabs.R              363     206  43.25%   68-98, 125, 140-320, 352, 470-473, 477-480, 484-487, 502, 536, 589-592
R/module_session_info.R              18       7  61.11%   35-41
R/module_snapshot_manager.R         265     194  26.79%   89-94, 103-112, 120-144, 163-164, 181-204, 208-223, 225-232, 239-269, 273, 277-281, 283-289, 292-305, 308-316, 346-360, 363-374, 377-391, 404
R/module_teal_data.R                149      76  48.99%   43-149
R/module_teal_lockfile.R            131      69  47.33%   33-37, 45-57, 60-62, 76, 86-88, 92-96, 100-102, 110-119, 122, 124, 126-127, 142-146, 161-162, 177-186, 196-201
R/module_teal_with_splash.R          33      33  0.00%    24-61
R/module_teal.R                     206      84  59.22%   50-115, 133, 144-145, 186, 204-220, 222
R/module_transform_data.R           116       7  93.97%   20, 46, 130-134
R/modules.R                         291      53  81.79%   174-178, 233-236, 360-380, 388, 394, 571-577, 590-598, 613-628, 661, 674
R/reporter_previewer_module.R        41      41  0.00%    22-85
R/show_rcode_modal.R                 31      31  0.00%    17-49
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 20       0  100.00%
R/teal_data_utils.R                  10       0  100.00%
R/teal_modifiers.R                   71      71  0.00%    26-214
R/teal_reporter.R                    70       8  88.57%   69, 77-82, 131-132, 135, 152
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   377     377  0.00%    57-756
R/utils.R                           283      60  78.80%   402-451, 499-510, 531-540
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   118-406
R/zzz.R                              16      12  25.00%   4-19
TOTAL                              3742    1732  53.71%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: c97b162

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@vedhav
Copy link
Contributor

vedhav commented Jul 25, 2025

The Show R code modal screenshots are outdated. Please update them.

Copy link
Contributor

github-actions bot commented Jul 30, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@chizapoth
Copy link

I have read the CLA Document and I hereby sign the CLA

@llrs-roche
Copy link
Contributor Author

@vedhav Thanks for the reminder!
@chizapoth I've updated the images, let me know if they are a bit blurry, too small or they are good.

Copy link

@chizapoth chizapoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • (this is my first PR review for the teal project)
  • I've tested to compile the vignette and viewed it locally, looks good!
  • the screenshots are updated
  • the text changes are good (I can't tell yet what they do from my limited experience with teal, but the language is fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Vignette]: Update Reproducibility section
3 participants