-
-
Notifications
You must be signed in to change notification settings - Fork 47
Update the reproducibility section of "Including Data in teal Applications" vignette's #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Unit Tests Summary 1 files 25 suites 2m 9s ⏱️ Results for commit c97b162. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit 7b9f9dc ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: c97b162 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
The |
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
@vedhav Thanks for the reminder! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- (this is my first PR review for the teal project)
- I've tested to compile the vignette and viewed it locally, looks good!
- the screenshots are updated
- the text changes are good (I can't tell yet what they do from my limited experience with teal, but the language is fine)
Pull Request
Fixes #1543