-
-
Notifications
You must be signed in to change notification settings - Fork 50
[DO-NOT-MERGE] Create how-to guide to migrate from old "Show R Code"/"Reporter #1637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placing an unresolved comment here to block any accidental merge
Code Coverage SummaryDiff against mainResults for commit: 34ab490 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 29 suites 2m 36s ⏱️ Results for commit 34ab490. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit 4724f2b ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a migration guide for teal v1.1.0, documenting changes to the module system that introduce a new teal_reporter object, simplify reporting interfaces, and automate code reproducibility features. The guide helps module developers transition from the deprecated "Show R Code"/Reporter implementation to the new unified system.
Key Changes:
- Documents the introduction of
teal_reporterobject andteal_cardclass for managing reports - Provides step-by-step migration instructions for updating existing modules
- Includes concrete code examples from the
tm_a_regressionmodule showing before/after changes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Marcin <[email protected]>
llrs-roche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two comments, one about teal_card (I don't mention teal_reporter as I think it is clearly explained that it is automatic, but that doesn't happen for teal_card), and one about the summary at the end.
The examples are great and it shows how much of an improvement this feature is.
llrs-roche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this because I think it is short, to the point and helpful. But I am sure other people on the team will have good suggestions too. I would also ask around to check this document.
|
Hey @averissimo , in general amazing job : ) just left few small comments |
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
Signed-off-by: André Veríssimo <[email protected]>
Signed-off-by: André Veríssimo <[email protected]>
Signed-off-by: André Veríssimo <[email protected]>
Pull Request
Do not merge
This document will be moved to
Discussionsection, this is here purely for review