Skip to content

fix(collector): cleaned up request objects after agent host lookup #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(collector): cleaned up request objects after agent host lookup #1908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c21d78
fix(collector): destroyed request on error or timeout
kirrg001 Aug 4, 2025
3ccb76f
chore: fixed lint
kirrg001 Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/collector/src/announceCycle/agentHostLookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ function checkHost(host, cb) {
}
};

/** @type {import('http').ClientRequest} */
let req;

try {
/**
* TODO:
Expand Down Expand Up @@ -173,6 +175,11 @@ function checkHost(host, cb) {
}

req.on('timeout', function onTimeout() {
if (req.destroyed) {
return;
}

req.destroy();
handleCallback(
new Error(`The attempt to connect to the Instana host agent on ${host}:${agentOpts.port} has timed out`)
);
Expand All @@ -182,6 +189,11 @@ function checkHost(host, cb) {
req.setTimeout(requestTimeout);

req.on('error', err => {
if (req.destroyed) {
return;
}

req.destroy();
handleCallback(
new Error(
`The attempt to connect to the Instana host agent on ${host}:${agentOpts.port} has failed with the following ` +
Expand Down