Skip to content

Conversation

@kirrg001
Copy link
Contributor

));
});

describe('with many dependencies', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you comment out the fix in dependencies.js, the test will fail and not report any dependencies because it never ends.

@kirrg001 kirrg001 marked this pull request as ready for review October 23, 2025 08:23
@kirrg001 kirrg001 requested a review from a team as a code owner October 23, 2025 08:23
Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix ❤️

@aryamohanan aryamohanan merged commit 7e0b029 into main Oct 23, 2025
1 check was pending
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants