fix(redis): resolved pool instrumentation to use instance instead of prototype #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilash-sivan
approved these changes
Oct 24, 2025
kirrg001
requested changes
Oct 27, 2025
aryamohanan
force-pushed
the
fix-redis-pool
branch
from
bc1759c to
c1bd72a
Compare
…prototype The instrumentation for pool was returning the prototype instead of the instance, which is wrong and will broke private-field access.
aryamohanan
force-pushed
the
fix-redis-pool
branch
from
52140cf to
f04aaf5
Compare
|
kirrg001
reviewed
Oct 28, 2025
kirrg001
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instrumentation for pool was returning the prototype instead of the instance, which is wrong and will broke private-field access.
Redis v5.9.0 introduced change, which modified how createClientPool initializes the client, causing private fields like #isOpen to become inaccessible when wrapped by our tracer.