-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InstructLab and Deepsearch #106
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,52 @@ | ||||||||||||||
|
||||||||||||||
# DeepSearch + InstructLab Integration Proposal | ||||||||||||||
|
||||||||||||||
<https://github.com/DS4SD> | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved below where DeepSearch is first mentioned |
||||||||||||||
|
||||||||||||||
## Why is a Conversion Tool Necessary? | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
Managing submissions for the open-source InstructLab project has revealed a significant bottleneck in processing | ||||||||||||||
knowledge documents. For the InstructLab backend to effectively utilize these documents, they must be in markdown | ||||||||||||||
format. Currently, we only accept Wikipedia articles, but the built-in conversion tool is inadequate. Internally at | ||||||||||||||
IBM, and other companies, many knowledge submissions are in multiple document formats, including PDF format, | ||||||||||||||
necessitating conversion to markdown before being used in InstructLab. | ||||||||||||||
Comment on lines
+8
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
Existing open-source methods, such as PanDoc, are inconsistent. While they preserve text, they struggle with parsing | ||||||||||||||
tables and special symbols, as evidenced by issues in PR #1154 of the taxonomy repo in the InstructLab project. Other | ||||||||||||||
open-source solutions have similar shortcomings. | ||||||||||||||
Comment on lines
+14
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
## Why DeepSearch? | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
IBM's DeepSearch software excels in document conversion, outperforming traditional open-source methods. Utilizing a | ||||||||||||||
computer vision model layer, it accurately parses content in the files, including titles, headers, and tables. | ||||||||||||||
Additionally, it automatically implements RAG layers for models, which could benefit the InstructLab process in | ||||||||||||||
the future. | ||||||||||||||
Comment on lines
+20
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
## Integration Proposal | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
To maintain the open-source nature of the project while leveraging the strengths of DeepSearch, we propose a | ||||||||||||||
two-pronged approach: | ||||||||||||||
Comment on lines
+27
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
### Open-Source Conversion | ||||||||||||||
|
||||||||||||||
- Implement a basic document conversion tool in the UI using an open-source method such as PanDoc. This tool will be | ||||||||||||||
lightweight and easily hosted, ensuring it can be used and improved by the community. | ||||||||||||||
Comment on lines
+30
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
### DeepSearch Integration | ||||||||||||||
|
||||||||||||||
- Enable the UI to switch the conversion endpoint to DeepSearch, allowing high-fidelity markdown conversions for | ||||||||||||||
backend use. This approach maintains an open-source version while benefiting from DeepSearch's superior | ||||||||||||||
conversion capabilities. | ||||||||||||||
Comment on lines
+35
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
IBM Research and the DeepSearch team will host the DeepSearch endpoint for the open-source community. This | ||||||||||||||
arrangement benefits the community by streamlining contributions and provides data and exposure for the DeepSearch | ||||||||||||||
project. IBM's contribution underscores its commitment to supporting and improving open-source projects. | ||||||||||||||
Comment on lines
+41
to
+43
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
This integration will highlight the value of DeepSearch, highlighting their potential for those integrating | ||||||||||||||
InstructLab into their workflows. If the volume of community requests becomes unsustainable for the DeepSearch team, | ||||||||||||||
we hope for ample notification to allow the community to find alternative solutions. By then, we anticipate that the | ||||||||||||||
open-source versions will have improved sufficiently, or the value of the integration will justify continued support. | ||||||||||||||
Comment on lines
+45
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
||||||||||||||
By adopting this two-pronged approach, we ensure the integrity of the open-source project while leveraging IBM's | ||||||||||||||
advanced DeepSearch capabilities. This strategy balances community collaboration with innovative technology, | ||||||||||||||
fostering innovation and improvement in document processing for the InstructLab project. | ||||||||||||||
Comment on lines
+50
to
+52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.