reorg main function; add 'hpu' option w/o implementation #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `main` training function needed to be broken down into smaller functions for readability/testability. WORLD_SIZE, LOCAL_RANK, and RANK have also been extracted and made global constants since they are set by the administrating multiprocessing launcher (torchrun, in our case). HPU configuration options and checks are also added. Signed-off-by: James Kunstle <[email protected]>
JamesKunstle
commented
Nov 11, 2024
| disable_flash_attn=args.disable_flash_attn, use_dolomite=args.use_dolomite | ||
| ) | ||
|
|
||
| tokenizer = configure_tokenizer( |
There was a problem hiding this comment.
I would have named this setup_tokenizer but that name would shadow the imported function.
JamesKunstle
commented
Nov 11, 2024
| train_loader = setup_dataloader( | ||
| dataset, | ||
| tokenizer.pad_token_id, | ||
| this happens sometimes when we have more GPUs than data to process. In this case |
There was a problem hiding this comment.
will fix this docstring
RobotSail
reviewed
Nov 12, 2024
| mock_len=args.mock_len, | ||
| ) | ||
| # will try to make multipack work if possible. | ||
| sampler_type: str = "multipack" |
There was a problem hiding this comment.
: str here is redundant - it's inferred by the assignment
RobotSail
reviewed
Nov 12, 2024
|
This pull request has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. |
|
This pull request has merge conflicts that must be resolved before it can be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
maintraining function needed to be broken down into smallerfunctions for readability/testability.
WORLD_SIZE, LOCAL_RANK, and RANK have also been extracted and made
global constants since they are set by the administrating
multiprocessing launcher (torchrun, in our case).
HPU configuration options and checks are also added.
Signed-off-by: James Kunstle [email protected]