Skip to content

BENB add direction logic to smooth encoder #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benblaise-intech merged 1 commit into from
Jul 6, 2026
Merged

BENB add direction logic to smooth encoder #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions common/src/c/grid_ui_encoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ void grid_ui_element_encoder_page_change_cb(struct grid_ui_element* ele, uint8_t
// }
}

#define SIGN(x) (((x) > 0) - ((x) < 0))

int16_t grid_ui_encoder_rotation_delta(uint8_t old_value, uint8_t new_value, uint8_t detent, int8_t* last_leave_dir) {

// lookup table indexed by a combination of old and new encoder output AB
Expand All @@ -158,18 +160,24 @@ int16_t grid_ui_encoder_rotation_delta(uint8_t old_value, uint8_t new_value, uin
// 4-bit state value holding old and new 2-bit encoder quadratures
uint8_t combined_state = (old_value & 0b11) << 2 | (new_value & 0b11);

int16_t dir = encoder_heading[combined_state];

int16_t delta = 0;

// non-detent encoders should produce deltas upon every quadrature change
// non-detent encoders should produce deltas upon every quadrature change,
// when that change agrees with the direction of the previous change
if (!detent) {
delta = encoder_heading[combined_state];

if (SIGN(dir) == SIGN(*last_leave_dir)) {
delta = *last_leave_dir = dir;
} else {
*last_leave_dir = dir;
}
}
// detent encoders here should only a produce delta upon entering a detent,
// and only if the would-be delta matches the direction lock
else {

int16_t dir = encoder_heading[combined_state];

// leaving a detent into either neighboring quadrature sets direction lock
static uint8_t update_lock[] = {
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0,
Expand Down
Loading