identity service changes - #62
Merged
Merged
Conversation
…sk-core - Add identity API client, models, and router in kiosk_core - Add Auth components, camera/voice capture hooks in kiosk-ui - Extend ordering repository/service and config for identity flow Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…es build refs - make down: pass --profile identity when IDENTITY is enabled so identity-service is included in the resolved service set and actually stops, matching up/build behavior. - Remove EAL_PATH/edge-ai-libraries source-build logic from the Makefile. audio-analyzer and text-to-speech live in a separate repository and are now always pulled pre-built from Docker Hub (make build), for both REGISTRY=true and REGISTRY=false, using the tags already declared in docker-compose.yml. - docker-compose.yml: remove the now-unreachable build: blocks and edge-ai-libraries sibling-repo references for audio-analyzer and text-to-speech; update header comment accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sachinkaushik
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Smart Kiosk Assistant with an optional identity (biometric) login/registration flow in the kiosk UI, adds corresponding kiosk-core proxy/support endpoints and models, and adjusts build/compose behavior to always pull certain prebuilt services. It also introduces logic intended to clear stale draft carts when a new session begins and updates identity-service docs/config to reflect the now-wired verify/register flows.
Changes:
- Add kiosk-ui
AuthGate(login/register + camera/voice capture) gated by a runtime backend capability endpoint. - Add kiosk-core identity register proxy models/client/API plus a new always-on
GET /api/v1/identity/enabled. - Update build/compose to always pull
audio-analyzer/text-to-speechas registry images, and add ordering draft-cart cleanup support.
Reviewed changes
Copilot reviewed 24 out of 29 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| smart-kiosk-assistant/Makefile | Reworks identity flag handling and changes build behavior to always pull registry-only services. |
| smart-kiosk-assistant/main.py | Adds identity capability endpoint and draft-cart clearing hook; converts some endpoints to async. |
| smart-kiosk-assistant/kiosk-ui/tsconfig.tsbuildinfo | Updates TS build metadata (generated artifact). |
| smart-kiosk-assistant/kiosk-ui/src/types.ts | Adds identity-related request/response/profile TypeScript types. |
| smart-kiosk-assistant/kiosk-ui/src/main.tsx | Wraps the app in AuthGate. |
| smart-kiosk-assistant/kiosk-ui/src/hooks/useVoiceCapture.ts | Adds single-clip voice capture with VAD for identity flows. |
| smart-kiosk-assistant/kiosk-ui/src/hooks/useCamera.ts | Adds camera preview + JPEG frame capture hook. |
| smart-kiosk-assistant/kiosk-ui/src/components/Auth/RegisterScreen.tsx | Implements self-service identity registration UI (face + voice capture). |
| smart-kiosk-assistant/kiosk-ui/src/components/Auth/LoginScreen.tsx | Implements identity login UI (face + voice verification). |
| smart-kiosk-assistant/kiosk-ui/src/components/Auth/AuthSuccessToast.tsx | Adds post-auth success toast overlay. |
| smart-kiosk-assistant/kiosk-ui/src/components/Auth/AuthGate.tsx | Implements identity gate/bypass logic based on backend capability. |
| smart-kiosk-assistant/kiosk-ui/src/api/identityApi.ts | Adds UI API wrapper for identity enabled/challenge/verify/register calls. |
| smart-kiosk-assistant/kiosk-ui/dist/index.html | Updates built UI asset references. |
| smart-kiosk-assistant/kiosk-ui/dist/assets/index-ZH1LMXpw.css | Adds updated built CSS asset. |
| smart-kiosk-assistant/kiosk-ui/dist/assets/index-CuX-224k.css | Removes previous built CSS asset. |
| smart-kiosk-assistant/kiosk_core/ordering/service.py | Adds service method to clear stale draft carts for a user. |
| smart-kiosk-assistant/kiosk_core/ordering/repository.py | Adds repository support to delete draft orders for a user. |
| smart-kiosk-assistant/kiosk_core/identity/models.py | Adds kiosk-core register request/response and identity status response models. |
| smart-kiosk-assistant/kiosk_core/identity/client.py | Adds identity-service register client call. |
| smart-kiosk-assistant/kiosk_core/identity/api.py | Adds kiosk-core /register proxy endpoint with validation. |
| smart-kiosk-assistant/kiosk_core/config.py | Adds DEFAULT_ORDERING_USER_ID config value. |
| smart-kiosk-assistant/kiosk_core/audio_session.py | Uses DEFAULT_ORDERING_USER_ID instead of a hardcoded fallback. |
| smart-kiosk-assistant/identity-service/README.md | Updates docs to reflect completed verify/register and kiosk-core proxy + UI gate. |
| smart-kiosk-assistant/identity-service/identity_core/service.py | Adds additional logging for verification rejection cases. |
| smart-kiosk-assistant/docker-compose.yml | Removes local build contexts for audio-analyzer/TTS; clarifies always-pulled behavior. |
| smart-kiosk-assistant/configs/identity/identity_config.yaml | Tunes fusion weights/thresholds and documents rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ng I/O, and build config - Only clear stale draft cart when starting a genuinely new conversation (empty request.history), not on every voice turn — prevents wiping an in-progress cart mid-conversation across mic-press session restarts. - Run blocking start_file_session (file I/O under lock) in a threadpool so the async route no longer blocks the event loop. - Fix Makefile build target to use the resolved _DOCKER_REGISTRY prefix when pulling audio-analyzer/text-to-speech, honoring a user-provided REGISTRY value instead of always defaulting to _ENV_REGISTRY. - Correct useVoiceCapture.ts JSDoc silence duration (~1.5s, matching TRAILING_SILENCE_MS) instead of the stale ~700ms figure. - Stop tracking the generated kiosk-ui/tsconfig.tsbuildinfo build cache and ignore *.tsbuildinfo going forward. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sumanaga
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.